-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disable stalled stream protection on empty bodies and after read complete #3644
Changes from 12 commits
f84e5fb
07d5e51
a9d19d4
c30e54d
bc4b1db
22a0e30
fccc930
711fe26
e08df6a
028af04
e2e3824
1b282f2
287dd10
a07103b
3b27db8
cd893fc
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
[package] | ||
name = "aws-smithy-runtime-api" | ||
version = "1.6.0" | ||
version = "1.6.1" | ||
authors = ["AWS Rust SDK Team <[email protected]>", "Zelda Hessler <[email protected]>"] | ||
description = "Smithy runtime types." | ||
edition = "2021" | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,7 +13,11 @@ | |
use aws_smithy_types::config_bag::{Storable, StoreReplace}; | ||
use std::time::Duration; | ||
|
||
const DEFAULT_GRACE_PERIOD: Duration = Duration::from_secs(5); | ||
/// The default grace period for stalled stream protection. | ||
/// | ||
/// When a stream stalls for longer than this grace period, the stream will | ||
/// return an error. | ||
pub const DEFAULT_GRACE_PERIOD: Duration = Duration::from_secs(20); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why pub? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. b/c there's an SSP option struct in |
||
|
||
/// Configuration for stalled stream protection. | ||
/// | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
[package] | ||
name = "aws-smithy-runtime" | ||
version = "1.5.2" | ||
version = "1.5.1" | ||
Velfi marked this conversation as resolved.
Show resolved
Hide resolved
|
||
authors = ["AWS Rust SDK Team <[email protected]>", "Zelda Hessler <[email protected]>"] | ||
description = "The new smithy runtime crate" | ||
edition = "2021" | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,10 +4,12 @@ | |
*/ | ||
|
||
use super::Throughput; | ||
use aws_smithy_runtime_api::client::stalled_stream_protection::StalledStreamProtectionConfig; | ||
use aws_smithy_runtime_api::client::stalled_stream_protection::{ | ||
StalledStreamProtectionConfig, DEFAULT_GRACE_PERIOD, | ||
}; | ||
use std::time::Duration; | ||
|
||
/// A collection of options for configuring a [`MinimumThroughputBody`](super::MinimumThroughputBody). | ||
/// A collection of options for configuring a [`MinimumThroughputBody`](super::MinimumThroughputDownloadBody). | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this was correct as it was I think, it applies to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I did it to avoid the deprecation message:
|
||
#[derive(Debug, Clone)] | ||
pub struct MinimumThroughputBodyOptions { | ||
/// The minimum throughput that is acceptable. | ||
|
@@ -69,6 +71,13 @@ impl MinimumThroughputBodyOptions { | |
} | ||
} | ||
|
||
const DEFAULT_MINIMUM_THROUGHPUT: Throughput = Throughput { | ||
bytes_read: 1, | ||
per_time_elapsed: Duration::from_secs(1), | ||
}; | ||
|
||
const DEFAULT_CHECK_WINDOW: Duration = Duration::from_secs(1); | ||
|
||
impl Default for MinimumThroughputBodyOptions { | ||
fn default() -> Self { | ||
Self { | ||
|
@@ -87,14 +96,6 @@ pub struct MinimumThroughputBodyOptionsBuilder { | |
grace_period: Option<Duration>, | ||
} | ||
|
||
const DEFAULT_GRACE_PERIOD: Duration = Duration::from_secs(0); | ||
const DEFAULT_MINIMUM_THROUGHPUT: Throughput = Throughput { | ||
bytes_read: 1, | ||
per_time_elapsed: Duration::from_secs(1), | ||
}; | ||
|
||
const DEFAULT_CHECK_WINDOW: Duration = Duration::from_secs(1); | ||
|
||
impl MinimumThroughputBodyOptionsBuilder { | ||
/// Create a new `MinimumThroughputBodyOptionsBuilder`. | ||
pub fn new() -> Self { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will
aws-sdk-rust#1141
(for CopyObject) andaws-sdk-rust#1146
(for MultipartUpload) be addressed by this PR?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CopyObject is going to be resolved in a separate PR that I linked in an earlier post. MPU should be fixed by this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha, maybe we should remove
aws-sdk-rust#1141
fromreferences
then?