New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compiling S3 crate for wasm #3590

Merged

ysaito1001 merged 10 commits into main from ysaito/fix-compiling-s3-for-wasm

Apr 18, 2024

Contributor

ysaito1001 commented Apr 18, 2024 •

edited

Loading

Motivation and Context

Running cargo build --target wasm32-unknown-unknown --no-default-features on an S3 crate has stopped working since #3465 with the following error:

error: the wasm*-unknown-unknown targets are not supported by default, you may need to enable the "js" feature. For more information see: https://docs.rs/getrandom/#webassembly-support
   --> /Users/[REDACTED]/.cargo/registry/src/index.crates.io-6f17d22bba15001f/getrandom-0.2.14/src/lib.rs:352:9
    |
352 | /         compile_error!("the wasm*-unknown-unknown targets are not supported by \
353 | |                         default, you may need to enable the \"js\" feature. \
354 | |                         For more information see: \
355 | |                         https://docs.rs/getrandom/#webassembly-support");
    | |________________________________________________________________________^

To address the issue, this PR updates an S3's dependency on ahash in a way that disables default features.

Testing

Updated the existing test integration-tests/webassembly so that check-aws-sdk-standalone-integration-tests will run cargo check aws-sdk-s3 against both wasm32-wasi and wasm32-unknown-unknown (the updated check would break if we removed default-features = false from the ahash dependency).

Checklist

I have updated CHANGELOG.next.toml if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

ysaito1001 added 2 commits

April 17, 2024 16:45


          Disable default features for ahash

f9ebf0a


          Add CI check to build SDK crates for wasm

928151c

github-actions bot commented Apr 18, 2024

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
No codegen difference in the Client Test
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.


          Only check SDK crates for wasm build

04ff07f

github-actions bot commented Apr 18, 2024

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
No codegen difference in the Client Test
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.


          Fix condition for detecting SDK crates

b43a2f8

github-actions bot commented Apr 18, 2024

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
No codegen difference in the Client Test
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

ysaito1001 added 2 commits

April 18, 2024 12:22


          Revert check-only-aws-sdk-services

951aaae


          Run cargo check on wasm32-unknown-unknown

202dded

github-actions bot commented Apr 18, 2024

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
No codegen difference in the Client Test
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.


          Fix the key target under build

6c044d2

github-actions bot commented Apr 18, 2024

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
No codegen difference in the Client Test
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.


          Update CHANGELOG.next.toml

29afef7

ysaito1001 marked this pull request as ready for review

April 18, 2024 19:30

ysaito1001 requested review from a team as code owners

April 18, 2024 19:30

ysaito1001 added the needs-sdk-review label


          Merge branch 'main' into ysaito/fix-compiling-s3-for-wasm

d02f36a

jdisanti approved these changes

View reviewed changes

aws/sdk/integration-tests/test.sh Show resolved Hide resolved

github-actions bot commented Apr 18, 2024

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
No codegen difference in the Client Test
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.


          Add explanatory comments for --target wasm32-wasi

This commit is related to #3590 (comment)

ysaito1001 enabled auto-merge

April 18, 2024 20:52

github-actions bot commented Apr 18, 2024

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
No codegen difference in the Client Test
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

ysaito1001 added this pull request to the merge queue

Merged via the queue into main with commit 6b59ba2

43 of 44 checks passed

ysaito1001 deleted the ysaito/fix-compiling-s3-for-wasm branch

April 18, 2024 21:47

ysaito1001 mentioned this pull request

Introduction of ahash as dependency in s3 breaks webassembly(wasm) support awslabs/aws-sdk-rust#1131

Closed

Velfi removed the needs-sdk-review label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet