Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reexport EventReceiver in a generated client crate #3305

Merged
merged 7 commits into from
Dec 11, 2023

Conversation

ysaito1001
Copy link
Contributor

@ysaito1001 ysaito1001 commented Dec 11, 2023

Motivation and Context

Adds re-export for EventReceiver in a generated client crate

Description

EventReceiver was added in #3114 but the struct itself could not be referenced as pub. Our SDK integration tests did not break in the said PR because they only called the next method on it and never referred to that struct name.

This PR adds a re-export for EventReceiver in case customers need to refer to the name in their code.

Testing

Added a unit test and edited a transcribestreaming integration test to verify the re-export.

Checklist

  • I have updated CHANGELOG.next.toml if I made changes to the smithy-rs codegen or runtime crates
  • I have updated CHANGELOG.next.toml if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ysaito1001 ysaito1001 changed the base branch from main to smithy-rs-release-1.x.y December 11, 2023 20:39
Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

@ysaito1001 ysaito1001 marked this pull request as ready for review December 11, 2023 20:56
@ysaito1001 ysaito1001 requested review from a team as code owners December 11, 2023 20:56
Copy link
Collaborator

@rcoh rcoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. At some point in the future, we can change this to use automatic re-export

Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

@ysaito1001 ysaito1001 enabled auto-merge (squash) December 11, 2023 21:14
@ysaito1001 ysaito1001 merged commit 9f0ba85 into smithy-rs-release-1.x.y Dec 11, 2023
41 checks passed
@ysaito1001 ysaito1001 deleted the ysaito/reexport-event-receiver branch December 11, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants