Clean up re-exports and improve 'BuildError' conversions #3173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcoh
force-pushed
the
config-re-exports-cleanup
branch
from
f1e47fc
to
1e7968a
Compare
rcoh
requested review from
jdisanti,
Velfi and
ysaito1001
and removed request for
Velfi
jdisanti
reviewed
Nov 10, 2023
Comment on lines
-93
to
92
| use #{IntoShared}; | ||
| #{StaticUriEndpointResolver}::uri(url).into_shared() |
There was a problem hiding this comment.
This compiles? How does it know where into_shared came from?
There was a problem hiding this comment.
it's re-exported above
| * Although it is not always possible to use this, this is the preferred method for using types in config customizations | ||
| * and ensures that your type will be re-exported if it is used. | ||
| */ | ||
| fun configReexport(type: RuntimeType): RuntimeType = RuntimeType.forInlineFun(type.name, module = ClientRustModule.config) { |
There was a problem hiding this comment.
In an ideal world, I prefer to have all the re-exports in one place, but I understand the need to make them conditional and how that's easier with this approach. That said, I don't think we should use this for re-exports that are supposed to always be present since then it could be easy to break one of these re-exports just by changing codegen in some other place.
There was a problem hiding this comment.
I see that but I think:
- It's easier to miss items
- We'll get a semver failure if we delete something by accident
There was a problem hiding this comment.
The other benefit is that in-situ, we're actually using the rexport which I think is a benefit. We could make non-conditional re-exports be runtime types though, not opposed to that.
rcoh
force-pushed
the
config-re-exports-cleanup
branch
from
1bf97f8
to
c9d67d4
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
jdisanti
approved these changes
Nov 10, 2023
ysaito1001
approved these changes
Nov 10, 2023
rcoh
added a commit
that referenced
this pull request
Nov 13, 2023
## Motivation and Context - Fixes #3171 - Fixes #3155 - Fixes #3172 ## Description - Add `configReExport` to make it easy and consistent to re-export types into the config module when they are used! - Add this for a bunch of types and clean up some (now) dead code - Re export `BuildError` - Enable converting from `BuildError` into `SdkError` There are probably more places this can be used, but I'd like to keep this change small to facilitate easy backport to 0.57. ## Testing CI ## Checklist <!--- If a checkbox below is not applicable, then please DELETE it rather than leaving it unchecked --> - [x] I have updated `CHANGELOG.next.toml` if I made changes to the smithy-rs codegen or runtime crates - [x] I have updated `CHANGELOG.next.toml` if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
rcoh
added a commit
that referenced
this pull request
Nov 13, 2023
## Motivation and Context - Fixes #3171 - Fixes #3155 - Fixes #3172 ## Description - Add `configReExport` to make it easy and consistent to re-export types into the config module when they are used! - Add this for a bunch of types and clean up some (now) dead code - Re export `BuildError` - Enable converting from `BuildError` into `SdkError` There are probably more places this can be used, but I'd like to keep this change small to facilitate easy backport to 0.57. ## Testing CI ## Checklist <!--- If a checkbox below is not applicable, then please DELETE it rather than leaving it unchecked --> - [x] I have updated `CHANGELOG.next.toml` if I made changes to the smithy-rs codegen or runtime crates - [x] I have updated `CHANGELOG.next.toml` if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
BuildErrorintoSdkError#3171ProvideCredentials#3155BuildError#3172Description
configReExportto make it easy and consistent to re-export types into the config module when they are used!BuildErrorBuildErrorintoSdkErrorThere are probably more places this can be used, but I'd like to keep this change small to facilitate easy backport to 0.57.
Testing
CI
Checklist
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesCHANGELOG.next.tomlif I made changes to the AWS SDK, generated SDK code, or SDK runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.