Retry additional classes of H2 errors #2971
Conversation
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
| if err.is_closed() { | ||
| return ConnectorError::io(err.into()); | ||
| } |
There was a problem hiding this comment.
Is this already covered by the first guard condition at line 205?
This PR adds two additional classes of retries tested: 1. GO_AWAY: awslabs/aws-sdk-rust#738 2. REFUSED_STREAM: awslabs/aws-sdk-rust#858 I tested 1 by using the example helpfully provided. The fix for 2 is untested and difficult to reproduce but since my fix for 1 worked, I'm confident that we're detecting the correct error class here.
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
has this been shipped yet? we'd like to solve for awslabs/aws-sdk-rust#738 |
|
Yeah this shipped for GO_AWAY specifically
…On Thu, Nov 23, 2023, 1:03 PM Fero ***@***.***> wrote:
has this been shipped yet? we'd like to solve for awslabs/aws-sdk-rust#738
<awslabs/aws-sdk-rust#738>
—
Reply to this email directly, view it on GitHub
<#2971 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADYKZYCCDTIAG2D56Q3BMDYF6FY5AVCNFSM6AAAAAA4MI3XDWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRUG44DONJXGA>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
|
Hey @rcoh thanks, I'm having a hard time figuring out when this was released. I don't see any entry referencing this PR in your changelog. We are using version 
|
|
it was released, but then a bad merge appears to have reverted these fixes. I'm re-fixing it now |
Draft pull request pending merge of #2970
Motivation and Context
Description
This PR adds two additional classes of retries tested:
I tested 1 by using the example helpfully provided. The fix for 2 is untested and difficult to reproduce but since my fix for 1 worked, I'm confident that we're detecting the correct error class here.
Testing
I used the example provided by the customer and validated the H2 GO_AWAY fix.
Checklist
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesCHANGELOG.next.tomlif I made changes to the AWS SDK, generated SDK code, or SDK runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.