Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Smithy to 1.35 #2892

Merged
merged 3 commits into from
Aug 1, 2023
Merged

Upgrade Smithy to 1.35 #2892

merged 3 commits into from
Aug 1, 2023

Conversation

jdisanti
Copy link
Collaborator

@jdisanti jdisanti commented Aug 1, 2023

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@github-actions
Copy link

github-actions bot commented Aug 1, 2023

A new generated diff is ready to view.

A new doc preview is ready to view.

@david-perez
Copy link
Contributor

Server-side restXml support is broken beyond repair, so excluding the newly added S3EscapeObjectKeyInUriLabel and S3EscapePathObjectKeyInUriLabel tests is fine. I'll remove the com.amazonaws.s3#AmazonS3 test suite from the server integration tests; in fact, I'm leaning towards removing the server restXml code all together to not give the impression to users that we actually support it.

As for the RestJsonQueryStringEscaping test, the test actually passes as-is. I had put in a hotfix while I waited for smithy-lang/smithy#1562 to land, but the fix was upstreamed and we're now consuming it. The test was further tweaked in smithy-lang/smithy#1759 to prepend a space to the query string, which is why my patch no longer worked. I've pushed a commit 3dddedf to remove my patch and just use Smithy's definition of the test.

@github-actions
Copy link

github-actions bot commented Aug 1, 2023

A new generated diff is ready to view.

A new doc preview is ready to view.

@jdisanti jdisanti marked this pull request as ready for review August 1, 2023 16:13
@jdisanti jdisanti requested review from a team as code owners August 1, 2023 16:13
@jdisanti jdisanti added this pull request to the merge queue Aug 1, 2023
Merged via the queue into main with commit 682dc7f Aug 1, 2023
@jdisanti jdisanti deleted the jdisanti-upgrade-smithy branch August 1, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants