-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Client examples that use the generic client have been added #2799
Conversation
A new generated diff is ready to view.
A new doc preview is ready to view. |
4fbae4e
to
f531651
Compare
A new generated diff is ready to view.
A new doc preview is ready to view. |
f531651
to
174f02f
Compare
A new generated diff is ready to view.
A new doc preview is ready to view. |
A new generated diff is ready to view.
A new doc preview is ready to view. |
8f3512c
to
19c34c3
Compare
A new generated diff is ready to view.
A new doc preview is ready to view. |
19c34c3
to
f69dfcc
Compare
A new generated diff is ready to view.
A new doc preview is ready to view. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Examples look good! I learnt a couple of things about smithy-rs clients too reading them. I've just left a ton of nits. Overall I'd also say that some examples feel redundant: they showcase features and behavior that other examples already cover.
It'd be great if we could run these examples in CI! Since all of the examples are stateless, we could write a simple integration test that spun up the Pokémon service and then invoked all of the examples.
examples/pokemon-service-client-usage/examples/trace-serialize.rs
Outdated
Show resolved
Hide resolved
examples/pokemon-service-client-usage/examples/trace-serialize.rs
Outdated
Show resolved
Hide resolved
examples/pokemon-service-client-usage/examples/trace-serialize.rs
Outdated
Show resolved
Hide resolved
examples/pokemon-service-client-usage/examples/use-config-bag.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for reviewing. I have consolidated examples and have fixed most of the nits.
A new generated diff is ready to view.
A new doc preview is ready to view. |
examples/pokemon-service-client-usage/examples/handling-errors.rs
Outdated
Show resolved
Hide resolved
examples/pokemon-service-client-usage/examples/retry-customize.rs
Outdated
Show resolved
Hide resolved
examples/pokemon-service-client-usage/examples/trace-serialize.rs
Outdated
Show resolved
Hide resolved
examples/pokemon-service-client-usage/examples/endpoint-resolver.rs
Outdated
Show resolved
Hide resolved
examples/pokemon-service-client-usage/examples/retry-classifier.rs
Outdated
Show resolved
Hide resolved
c9336cd
to
219013b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have incorporated the suggestions.
examples/pokemon-service-client-usage/examples/handling-errors.rs
Outdated
Show resolved
Hide resolved
examples/pokemon-service-client-usage/examples/retry-classifier.rs
Outdated
Show resolved
Hide resolved
examples/pokemon-service-client-usage/examples/retry-customize.rs
Outdated
Show resolved
Hide resolved
examples/pokemon-service-client-usage/examples/trace-serialize.rs
Outdated
Show resolved
Hide resolved
A new generated diff is ready to view.
A new doc preview is ready to view. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
examples/pokemon-service-client-usage/examples/use-config-bag.rs
Outdated
Show resolved
Hide resolved
219013b
to
a1366a2
Compare
A new generated diff is ready to view.
A new doc preview is ready to view. |
A new generated diff is ready to view.
A new doc preview is ready to view. |
…cies. Change Interceptor to Intercept.
A new generated diff is ready to view.
A new doc preview is ready to view. |
8da5e34
to
f38d413
Compare
A new generated diff is ready to view.
A new doc preview is ready to view. |
Motivation and Context
Example code that demonstrates the usage of pokemon-service-client.
Description
Examples have been added that show how to add middleware, configure retries, timeouts, and handle errors when calling operations on the pokemon-service.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.