Client examples that use the generic client have been added #2799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
drganjoo
force-pushed
the
client-examples
branch
from
4fbae4e
to
f531651
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
drganjoo
force-pushed
the
client-examples
branch
from
f531651
to
174f02f
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
drganjoo
force-pushed
the
client-examples
branch
from
8f3512c
to
19c34c3
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
drganjoo
force-pushed
the
client-examples
branch
from
19c34c3
to
f69dfcc
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
david-perez
requested changes
Oct 13, 2023
There was a problem hiding this comment.
Examples look good! I learnt a couple of things about smithy-rs clients too reading them. I've just left a ton of nits. Overall I'd also say that some examples feel redundant: they showcase features and behavior that other examples already cover.
It'd be great if we could run these examples in CI! Since all of the examples are stateless, we could write a simple integration test that spun up the Pokémon service and then invoked all of the examples.
examples/pokemon-service-client-usage/examples/trace-serialize.rs
Outdated
Show resolved
Hide resolved
examples/pokemon-service-client-usage/examples/trace-serialize.rs
Outdated
Show resolved
Hide resolved
examples/pokemon-service-client-usage/examples/trace-serialize.rs
Outdated
Show resolved
Hide resolved
examples/pokemon-service-client-usage/examples/use-config-bag.rs
Outdated
Show resolved
Hide resolved
drganjoo
commented
Oct 16, 2023
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
jdisanti
reviewed
Oct 16, 2023
examples/pokemon-service-client-usage/examples/handling-errors.rs
Outdated
Show resolved
Hide resolved
examples/pokemon-service-client-usage/examples/retry-customize.rs
Outdated
Show resolved
Hide resolved
examples/pokemon-service-client-usage/examples/trace-serialize.rs
Outdated
Show resolved
Hide resolved
david-perez
approved these changes
Oct 17, 2023
examples/pokemon-service-client-usage/examples/endpoint-resolver.rs
Outdated
Show resolved
Hide resolved
examples/pokemon-service-client-usage/examples/retry-classifier.rs
Outdated
Show resolved
Hide resolved
drganjoo
force-pushed
the
client-examples
branch
from
c9336cd
to
219013b
Compare
drganjoo
commented
Oct 18, 2023
examples/pokemon-service-client-usage/examples/handling-errors.rs
Outdated
Show resolved
Hide resolved
examples/pokemon-service-client-usage/examples/retry-classifier.rs
Outdated
Show resolved
Hide resolved
examples/pokemon-service-client-usage/examples/retry-customize.rs
Outdated
Show resolved
Hide resolved
examples/pokemon-service-client-usage/examples/trace-serialize.rs
Outdated
Show resolved
Hide resolved
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
jdisanti
approved these changes
Oct 18, 2023
examples/pokemon-service-client-usage/examples/use-config-bag.rs
Outdated
Show resolved
Hide resolved
drganjoo
force-pushed
the
client-examples
branch
from
219013b
to
a1366a2
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
added 2 commits
October 20, 2023 09:54
…cies. Change Interceptor to Intercept.
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
drganjoo
force-pushed
the
client-examples
branch
from
8da5e34
to
f38d413
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Example code that demonstrates the usage of pokemon-service-client.
Description
Examples have been added that show how to add middleware, configure retries, timeouts, and handle errors when calling operations on the pokemon-service.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.