Feature: Add smithy orchestrator #2447
Conversation
Velfi
force-pushed
the
refactor/add-smithy-orchestrator
branch
from
efb0065 to
bbf50cf
Compare
Velfi
force-pushed
the
refactor/add-smithy-orchestrator
branch
from
865d670 to
4753875
Compare
Co-authored-by: John DiSanti <[email protected]>
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
add: external-types.toml to new crates add: LICENSEs to new crates update: crate organization and naming update: interceptor errors per RFC 22 update: token bucket errors per RFC 22
fix: TODOs with no subject
add: docs.rs metadata to cargo toml of new crates
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
| pub type BoxError = Box<dyn std::error::Error + Send + Sync + 'static>; | ||
| pub type BoxFallibleFut<T> = Pin<Box<dyn Future<Output = Result<T, BoxError>>>>; | ||
|
|
||
| pub trait TraceProbe: Send + Sync + Debug { |
There was a problem hiding this comment.
No need to change or anything and just sharing some thoughts; I am unsure about whether this trait (and other traits in this module) should live in aws-smithy-runtime-api or aws-smithy-runtime as it feels like they act as "interface"s. More broadly, though, I haven't been able to convince myself what goes into an interface crate and what goes into an implementation crate as that separation, by design, may not be as clear as in other languages, e.g., Java or C++.
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
fix: move allowed external types to correct crate
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
See the RFC for more details
This PR adds a new, common framework for constructing client requests and handling service responses. My intentions are to:
Additionally, functionality that we currently provide like retries, logging, and auth with be incorporated into this new process in such a way as to make it more configurable and understandable.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.