-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use docker login when possible #2265
Merged
Merged
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
a3f06d2
Use docker login (wip)
rcoh e6a9a01
setup job hierarchy
rcoh 01cab22
Move save code to always run, fix throttling backoff
rcoh b232210
use ECR login
rcoh 2d34997
hax
rcoh 09ac023
Merge branch 'main' into docker-login-if-possible
rcoh f40cfa5
fix loop
rcoh fc66f41
Merge branch 'docker-login-if-possible' of github.com:awslabs/smithy-…
rcoh 6e85210
Merge branch 'main' into docker-login-if-possible
rcoh 0d64314
fix chmod on script
rcoh 396a43f
Merge branch 'docker-login-if-possible' of github.com:awslabs/smithy-…
rcoh badeb7c
backout changes to acquire-build-image
rcoh 2124e98
wip save a token
rcoh 288f477
Try actually logging in...
rcoh fedb329
bail
rcoh 85f7753
use a real token
rcoh 0a130cd
use a real token for all jobs
rcoh ed66404
use a real token for all jobs
rcoh 2906394
use a real token for all jobs
rcoh 0ff3997
fix docs, add more logs
rcoh 62c82ee
rename secret name
rcoh 936b560
Merge branch 'main' of github.com:awslabs/smithy-rs into docker-login…
rcoh d9d710b
docs, naming, nicer errors
rcoh e26dbda
Merge branch 'main' of github.com:awslabs/smithy-rs into docker-login…
rcoh 33d7cb1
wip
rcoh 7514885
fix CI
rcoh ffa2d71
refactor and add tests
rcoh a1607cf
remove hack
rcoh cc97fe8
Merge branch 'main' of github.com:awslabs/smithy-rs into docker-login…
rcoh dbc0025
fix bad merge
rcoh 1ee44b4
revert another bad commit
rcoh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this was unintentionally reverted. We definitely want this "Data limit exceeded" retry for forked PRs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh thanks I saw that and TODO but forgot