-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure the (in|ex)clusion of the Debug trait for containers per members' sensitive trait #2029
Configure the (in|ex)clusion of the Debug trait for containers per members' sensitive trait #2029
Commits on Nov 27, 2022
-
Removes Debug for shape with sensitive trait
This commit centralizes a place where the codegen excludes the Debug trait if a shape has the sensitive trait. Previously the exclusion was handled locally in each shape, e.g. StructureGenerator and EnumGenerator. However, that approach may overlook a certain shape we also need to treat as such. We now handle the exclusion of the Debug trait in one place, BaseSymbolMetadataProvider.
Configuration menu - View commit details
-
Copy full SHA for 5c78741 - Browse repository at this point
Copy the full SHA 5c78741View commit details -
Stop excluding the Debug trait locally
This commit updates EnumGenerator and StructureGenerator based on the change made to BaseSymbolMetadataProvider in the previous commit. Now that the exclusion of the Debug trait was centralized, those classes in question no longer need to do so individually.
Configuration menu - View commit details
-
Copy full SHA for 079eff0 - Browse repository at this point
Copy the full SHA 079eff0View commit details -
Implement a custom Debug trait in BuilderGenerator
This commit implements a custom Debug trait in BuilderGenerator now that the derived Debug trait is excluded from BaseSymbolMetadataProvider for the structure container. The implementation of the custom Debug trait pretty much follows that of StructureGenerator.
Configuration menu - View commit details
-
Copy full SHA for e72fe8c - Browse repository at this point
Copy the full SHA e72fe8cView commit details -
Implement a custom Debug trait in UnionGenerator
This commit implements a custom Debug trait in BuilderGenerator now that the derived Debug trait is excluded from BaseSymbolMetadataProvider for the union container. The implementation of the custom Debug trait pretty much follows that of EnumGenerator.
Configuration menu - View commit details
-
Copy full SHA for efc096f - Browse repository at this point
Copy the full SHA efc096fView commit details -
Implement a custom Debug trait in ServerBuilderGenerator
This commit implements a custom Debug trait in ServerBuilderGenerator now that the derived Debug trait is excluded from BaseSymbolMetadataProvider for the structure container. The implementation of the custom Debug trait pretty much follows that of StructureGenerator.
Configuration menu - View commit details
-
Copy full SHA for 46e23e5 - Browse repository at this point
Copy the full SHA 46e23e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for c70f2ad - Browse repository at this point
Copy the full SHA c70f2adView commit details
Commits on Nov 28, 2022
-
Merge branch 'ysaito/respect-sensitive-trait-for-enum' into ysaito/ha…
…ndle-sensitive-trait-in-single-place
Configuration menu - View commit details
-
Copy full SHA for b15d86e - Browse repository at this point
Copy the full SHA b15d86eView commit details -
Configuration menu - View commit details
-
Copy full SHA for a681108 - Browse repository at this point
Copy the full SHA a681108View commit details
Commits on Nov 29, 2022
-
Update Debug impl for UnionGenerator
This commit updates the implementation of a custom Debug trait impl for UnionGenerator. Turns out that in a Union, a member target can be marked as sensitive separately outside the Union. Therefore, the implementation of a custom Debug trait has two cases depending on where the sensitive trait appears, either it is applied to the whole Union or to a member target.
Configuration menu - View commit details
-
Copy full SHA for e3d24ed - Browse repository at this point
Copy the full SHA e3d24edView commit details -
Peek at member sensitivity for Debug trait (in|ex)clusion
This commit addresses #2029 (comment). With this change, structure shapes no longer need to exclude the Debug trait unconditionally. The upshot is that we may be able to avoid a custom Debug impl for a structure where the derived Debug will do, i.e. when there is no sensitive trait either at a container level or at a member level.
Configuration menu - View commit details
-
Copy full SHA for 824d7d6 - Browse repository at this point
Copy the full SHA 824d7d6View commit details
Commits on Dec 3, 2022
-
Remove statement that does not seem to take effect
This commit addresses #2029 (comment)
Configuration menu - View commit details
-
Copy full SHA for 0381da2 - Browse repository at this point
Copy the full SHA 0381da2View commit details -
Rename renderDebugImplForUnion -> renderFullyRedactedDebugImpl
This commit addresses #2029 (comment)
Configuration menu - View commit details
-
Copy full SHA for 0f8102b - Browse repository at this point
Copy the full SHA 0f8102bView commit details -
Rename renderDebugImplForUnionMemberWise -> renderDebugImpl
This commit addresses #2029 (comment)
Configuration menu - View commit details
-
Copy full SHA for 64f44ca - Browse repository at this point
Copy the full SHA 64f44caView commit details