Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure the (in|ex)clusion of the Debug trait for containers per members' sensitive trait #2029

Commits on Nov 27, 2022

  1. Removes Debug for shape with sensitive trait

    This commit centralizes a place where the codegen excludes the Debug
    trait if a shape has the sensitive trait. Previously the exclusion was
    handled locally in each shape, e.g. StructureGenerator and EnumGenerator.
    However, that approach may overlook a certain shape we also need to treat
    as such. We now handle the exclusion of the Debug trait in one place,
    BaseSymbolMetadataProvider.
    ysaito1001 committed Nov 27, 2022
    Configuration menu
    Copy the full SHA
    5c78741 View commit details
    Browse the repository at this point in the history
  2. Stop excluding the Debug trait locally

    This commit updates EnumGenerator and StructureGenerator based on the
    change made to BaseSymbolMetadataProvider in the previous commit.
    Now that the exclusion of the Debug trait was centralized, those
    classes in question no longer need to do so individually.
    ysaito1001 committed Nov 27, 2022
    Configuration menu
    Copy the full SHA
    079eff0 View commit details
    Browse the repository at this point in the history
  3. Implement a custom Debug trait in BuilderGenerator

    This commit implements a custom Debug trait in BuilderGenerator now that
    the derived Debug trait is excluded from BaseSymbolMetadataProvider for
    the structure container. The implementation of the custom Debug trait
    pretty much follows that of StructureGenerator.
    ysaito1001 committed Nov 27, 2022
    Configuration menu
    Copy the full SHA
    e72fe8c View commit details
    Browse the repository at this point in the history
  4. Implement a custom Debug trait in UnionGenerator

    This commit implements a custom Debug trait in BuilderGenerator now that
    the derived Debug trait is excluded from BaseSymbolMetadataProvider for
    the union container. The implementation of the custom Debug trait pretty
    much follows that of EnumGenerator.
    ysaito1001 committed Nov 27, 2022
    Configuration menu
    Copy the full SHA
    efc096f View commit details
    Browse the repository at this point in the history
  5. Implement a custom Debug trait in ServerBuilderGenerator

    This commit implements a custom Debug trait in ServerBuilderGenerator now
    that the derived Debug trait is excluded from BaseSymbolMetadataProvider
    for the structure container. The implementation of the custom Debug trait
    pretty much follows that of StructureGenerator.
    ysaito1001 committed Nov 27, 2022
    Configuration menu
    Copy the full SHA
    46e23e5 View commit details
    Browse the repository at this point in the history
  6. Add the Copyright header

    ysaito1001 committed Nov 27, 2022
    Configuration menu
    Copy the full SHA
    c70f2ad View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2022

  1. Merge branch 'ysaito/respect-sensitive-trait-for-enum' into ysaito/ha…

    …ndle-sensitive-trait-in-single-place
    ysaito1001 committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    b15d86e View commit details
    Browse the repository at this point in the history
  2. Update CHANGELOG.next.toml

    ysaito1001 committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    a681108 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2022

  1. Update Debug impl for UnionGenerator

    This commit updates the implementation of a custom Debug trait impl for
    UnionGenerator. Turns out that in a Union, a member target can be marked
    as sensitive separately outside the Union. Therefore, the implementation
    of a custom Debug trait has two cases depending on where the sensitive
    trait appears, either it is applied to the whole Union or to a member
    target.
    ysaito1001 committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    e3d24ed View commit details
    Browse the repository at this point in the history
  2. Peek at member sensitivity for Debug trait (in|ex)clusion

    This commit addresses #2029 (comment).
    With this change, structure shapes no longer need to exclude the Debug
    trait unconditionally. The upshot is that we may be able to avoid a
    custom Debug impl for a structure where the derived Debug will do, i.e.
    when there is no sensitive trait either at a container level or at a
    member level.
    ysaito1001 committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    824d7d6 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2022

  1. Remove statement that does not seem to take effect

    This commit addresses #2029 (comment)
    ysaito1001 committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    0381da2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0f8102b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    64f44ca View commit details
    Browse the repository at this point in the history