Fix FnStream generator polling to prevent poll-after-ready #1903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Velfi
approved these changes
Oct 24, 2022
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
ysaito1001
approved these changes
Oct 24, 2022
Comment on lines
+175
to
+178
| // smithy-rs#1902: there was a bug where we could continue to poll the generator after it | ||
| // had returned Poll::Ready. This test case leaks the tx half so that the channel stays open | ||
| // but the send side generator completes. By calling `poll` multiple times on the resulting future, | ||
| // we can trigger the bug and validate the fix. |
There was a problem hiding this comment.
Thank you for the explanatory comment!
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
#1902 :
FnStreamhad a bug where, under load, an async function was polled after already being doneDescription
This change wraps the generator in an option, nulling it after completion to prevent double-polling
Testing
Unit tests + all of the current paginator integration tests
Checklist
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesCHANGELOG.next.tomlif I made changes to the AWS SDK, generated SDK code, or SDK runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.