-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the PR Bot manually invokable #1632
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new generated diff is ready to view.
A new doc preview is ready to view. |
jdisanti
force-pushed
the
jdisanti-manual-invoke-pr-bot
branch
from
August 11, 2022 20:30
3bd0335
to
68338c5
Compare
A new generated diff is ready to view.
A new doc preview is ready to view. |
jdisanti
force-pushed
the
jdisanti-manual-invoke-pr-bot
branch
5 times, most recently
from
August 11, 2022 21:28
69bff96
to
cf4f7a5
Compare
A new generated diff is ready to view.
A new doc preview is ready to view. |
jdisanti
force-pushed
the
jdisanti-manual-invoke-pr-bot
branch
4 times, most recently
from
August 11, 2022 22:53
67198c2
to
e795bb7
Compare
jdisanti
force-pushed
the
jdisanti-manual-invoke-pr-bot
branch
from
August 11, 2022 22:55
e795bb7
to
4a1ffef
Compare
A new generated diff is ready to view.
A new doc preview is ready to view. |
DavidOgunsAWS
approved these changes
Aug 12, 2022
Velfi
approved these changes
Aug 15, 2022
A new generated diff is ready to view.
A new doc preview is ready to view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
When people outside the rust-sdk-owners or smithy-rs-server groups try to contribute to smithy-rs, the PR bot fails due to lack of permissions. This PR makes the PR bot manually invokable by maintainers so that on PRs where a codegen diff would be helpful, it should be possible.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.