-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test is PASS for RestJsonQueryTimestampDefaultRejectsDifferent8601Formats_case13 #1590
Test is PASS for RestJsonQueryTimestampDefaultRejectsDifferent8601Formats_case13 #1590
Conversation
Fixed with: smithy-lang/smithy#1319 Signed-off-by: Daniele Ahmed <[email protected]>
A new generated diff is ready to view.
A new doc preview is ready to view. |
Signed-off-by: Daniele Ahmed <[email protected]>
A new generated diff is ready to view.
A new doc preview is ready to view. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test will pass when this change is merged: smithy-lang/smithy#1319
When that change is merged, Smithy still has to publish a new version to Maven, and then we will need to make a PR updating smithy-rs to that new Smithy version. In said PR is when these lines will have to be removed from the list of failing tests, because the test will start passing, and our CI will fail because it currently expects it to fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
\0/
Ok, I can update this PR then |
Closing, superseded by #1623. |
Motivation and Context
The test will pass when this change is merged: smithy-lang/smithy#1319
Testing
In the generated code, change the URI with the one in smithy-lang/smithy#1319
Checklist
CHANGELOG.next.toml
if I made changes to the smithy-rs codegen or runtime cratesCHANGELOG.next.toml
if I made changes to the AWS SDK, generated SDK code, or SDK runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.