Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test is PASS for RestJsonQueryTimestampDefaultRejectsDifferent8601Formats_case13 #1590

Conversation

82marbag
Copy link
Contributor

Motivation and Context

The test will pass when this change is merged: smithy-lang/smithy#1319

Testing

In the generated code, change the URI with the one in smithy-lang/smithy#1319

Checklist

  • I have updated CHANGELOG.next.toml if I made changes to the smithy-rs codegen or runtime crates
  • I have updated CHANGELOG.next.toml if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@82marbag 82marbag requested a review from a team as a code owner July 28, 2022 08:45
@github-actions
Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

@github-actions
Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

Copy link
Contributor

@david-perez david-perez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test will pass when this change is merged: smithy-lang/smithy#1319

When that change is merged, Smithy still has to publish a new version to Maven, and then we will need to make a PR updating smithy-rs to that new Smithy version. In said PR is when these lines will have to be removed from the list of failing tests, because the test will start passing, and our CI will fail because it currently expects it to fail.

Copy link
Contributor

@crisidev crisidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\0/

@82marbag
Copy link
Contributor Author

The test will pass when this change is merged: awslabs/smithy#1319

When that change is merged, Smithy still has to publish a new version to Maven, and then we will need to make a PR updating smithy-rs to that new Smithy version. In said PR is when these lines will have to be removed from the list of failing tests, because the test will start passing, and our CI will fail because it currently expects it to fail.

Ok, I can update this PR then

@david-perez
Copy link
Contributor

Closing, superseded by #1623.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants