Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make OperationShape::NAME more structured #2634

Closed
hlbarber opened this issue Apr 25, 2023 · 1 comment
Closed

Make OperationShape::NAME more structured #2634

hlbarber opened this issue Apr 25, 2023 · 1 comment
Assignees
@82marbag
Labels
breaking-change This will require a breaking change ergonomics server Rust server SDK

Comments

@hlbarber
Copy link
Contributor

Currently, OperationShape::NAME is a &'static str.

We should create a dedicated ShapeId structure, which would have a form equal to OperationExtension and use it here instead.

This would remove the need for users to split the shape IDs themselves at runtime.
@hlbarber hlbarber added ergonomics breaking-change This will require a breaking change server Rust server SDK labels Apr 25, 2023
@82marbag 82marbag self-assigned this Apr 26, 2023
@82marbag 82marbag mentioned this issue May 8, 2023
Merged
2 tasks
82marbag added a commit that referenced this issue May 11, 2023
@82marbag
OperationShape::NAME as ShapeId (#2678)
9b340fb 
See #2634

## Checklist
<!--- If a checkbox below is not applicable, then please DELETE it
rather than leaving it unchecked -->
- [x] I have updated `CHANGELOG.next.toml` if I made changes to the
smithy-rs codegen or runtime crates
- [ ] I have updated `CHANGELOG.next.toml` if I made changes to the AWS
SDK, generated SDK code, or SDK runtime crates

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._

---------

Signed-off-by: Daniele Ahmed <[email protected]>
david-perez pushed a commit that referenced this issue May 18, 2023
@82marbag @david-perez
OperationShape::NAME as ShapeId (#2678)
3689772 
See #2634

## Checklist
<!--- If a checkbox below is not applicable, then please DELETE it
rather than leaving it unchecked -->
- [x] I have updated `CHANGELOG.next.toml` if I made changes to the
smithy-rs codegen or runtime crates
- [ ] I have updated `CHANGELOG.next.toml` if I made changes to the AWS
SDK, generated SDK code, or SDK runtime crates

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._

---------

Signed-off-by: Daniele Ahmed <[email protected]>
82marbag added a commit that referenced this issue May 22, 2023
@82marbag
OperationShape::NAME as ShapeId (#2678)
6d46675 
See #2634

Signed-off-by: Daniele Ahmed <[email protected]>
@82marbag 82marbag mentioned this issue May 22, 2023
Merged
2 tasks
david-perez pushed a commit that referenced this issue May 22, 2023
@82marbag @david-perez
OperationShape::NAME as ShapeId (#2678)
3dad4e3 
See #2634

## Checklist
<!--- If a checkbox below is not applicable, then please DELETE it
rather than leaving it unchecked -->
- [x] I have updated `CHANGELOG.next.toml` if I made changes to the
smithy-rs codegen or runtime crates
- [ ] I have updated `CHANGELOG.next.toml` if I made changes to the AWS
SDK, generated SDK code, or SDK runtime crates

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._

---------

Signed-off-by: Daniele Ahmed <[email protected]>
david-perez pushed a commit that referenced this issue May 22, 2023
@82marbag @david-perez
OperationShape::NAME as ShapeId (#2678)
0053a55 
See #2634

## Checklist
<!--- If a checkbox below is not applicable, then please DELETE it
rather than leaving it unchecked -->
- [x] I have updated `CHANGELOG.next.toml` if I made changes to the
smithy-rs codegen or runtime crates
- [ ] I have updated `CHANGELOG.next.toml` if I made changes to the AWS
SDK, generated SDK code, or SDK runtime crates

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._

---------

Signed-off-by: Daniele Ahmed <[email protected]>
hlbarber added a commit that referenced this issue Jun 9, 2023
@82marbag @hlbarber
OperationShape::NAME as ShapeId (#2678) (#2717)
5eb0927 
See #2634

## Checklist
<!--- If a checkbox below is not applicable, then please DELETE it
rather than leaving it unchecked -->
- [x] I have updated `CHANGELOG.next.toml` if I made changes to the
smithy-rs codegen or runtime crates
- [ ] I have updated `CHANGELOG.next.toml` if I made changes to the AWS
SDK, generated SDK code, or SDK runtime crates

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._

---------

Signed-off-by: Daniele Ahmed <[email protected]>
Co-authored-by: Harry Barber <[email protected]>
@hlbarber
Copy link
Contributor Author

#2717

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@82marbag 82marbag

Labels
breaking-change This will require a breaking change ergonomics server Rust server SDK
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@82marbag @hlbarber