-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate RuntimeError into protocol specific errors #1703
Labels
server
Rust server SDK
Comments
Merged
Progress towards this, removing the runtime |
david-perez
added a commit
that referenced
this issue
Mar 30, 2023
As outlined in the [Protocol Specific Errors] of the [Service Builder Improvements RFC], `RuntimeError` should be split up into smaller, protocol specific, errors which accurately model the failure cases of each protocol. The same goes for `RequestRejection`. Closes #1703. [Protocol Specific Errors]: https://github.com/awslabs/smithy-rs/blob/main/design/src/rfcs/rfc0020_service_builder.md#protocol-specific-errors [Service Builder Improvements RFC]: https://github.com/awslabs/smithy-rs/blob/main/design/src/rfcs/rfc0020_service_builder.md
david-perez
added a commit
that referenced
this issue
Mar 30, 2023
As outlined in the [Protocol Specific Errors] of the [Service Builder Improvements RFC], `RuntimeError` should be split up into smaller, protocol specific, errors which accurately model the failure cases of each protocol. The same goes for `RequestRejection`. Closes #1703. [Protocol Specific Errors]: https://github.com/awslabs/smithy-rs/blob/main/design/src/rfcs/rfc0020_service_builder.md#protocol-specific-errors [Service Builder Improvements RFC]: https://github.com/awslabs/smithy-rs/blob/main/design/src/rfcs/rfc0020_service_builder.md
david-perez
added a commit
that referenced
this issue
Apr 3, 2023
As outlined in the [Protocol Specific Errors] of the [Service Builder Improvements RFC], `RuntimeError` should be split up into smaller, protocol specific, errors which accurately model the failure cases of each protocol. The same goes for `RequestRejection`. Closes #1703. [Protocol Specific Errors]: https://github.com/awslabs/smithy-rs/blob/main/design/src/rfcs/rfc0020_service_builder.md#protocol-specific-errors [Service Builder Improvements RFC]: https://github.com/awslabs/smithy-rs/blob/main/design/src/rfcs/rfc0020_service_builder.md
unexge
pushed a commit
that referenced
this issue
Apr 24, 2023
As outlined in the [Protocol Specific Errors] of the [Service Builder Improvements RFC], `RuntimeError` should be split up into smaller, protocol specific, errors which accurately model the failure cases of each protocol. The same goes for `RequestRejection`. Closes #1703. [Protocol Specific Errors]: https://github.com/awslabs/smithy-rs/blob/main/design/src/rfcs/rfc0020_service_builder.md#protocol-specific-errors [Service Builder Improvements RFC]: https://github.com/awslabs/smithy-rs/blob/main/design/src/rfcs/rfc0020_service_builder.md
rcoh
pushed a commit
that referenced
this issue
Apr 24, 2023
As outlined in the [Protocol Specific Errors] of the [Service Builder Improvements RFC], `RuntimeError` should be split up into smaller, protocol specific, errors which accurately model the failure cases of each protocol. The same goes for `RequestRejection`. Closes #1703. [Protocol Specific Errors]: https://github.com/awslabs/smithy-rs/blob/main/design/src/rfcs/rfc0020_service_builder.md#protocol-specific-errors [Service Builder Improvements RFC]: https://github.com/awslabs/smithy-rs/blob/main/design/src/rfcs/rfc0020_service_builder.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As outlined in the Protocol Specific Errors of the Service Builder Improvements RFC,
RuntimeError
should be split up into smaller, protocol specific, errors which accurately model the failure cases of each protocol.In #1693 we have used a blanket implementation
which allows us to continue using
RuntimeError
for the moment being.As
RuntimeError
is behind a#[doc(hidden)]
our policy allows us to remove it without classifying it as a breaking change.The text was updated successfully, but these errors were encountered: