Skip to content

Commit

Permalink
Run TODO lint against more files (#2078)
Browse files Browse the repository at this point in the history
This change would have prevented me from committing what was reverted in
#2076
  • Loading branch information
david-perez authored Dec 13, 2022
1 parent 3fb9096 commit 30c6828
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 5 deletions.
7 changes: 2 additions & 5 deletions codegen-core/common-test-models/constraints.smithy
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ use smithy.framework#ValidationException
@title("ConstraintsService")
service ConstraintsService {
operations: [
// TODO Rename as {Verb}[{Qualifier}]{Noun}: https://github.com/awslabs/smithy-rs/pull/1342#discussion_r980936650
ConstrainedShapesOperation,
ConstrainedHttpBoundShapesOperation,
ConstrainedRecursiveShapesOperation,
Expand Down Expand Up @@ -880,10 +879,8 @@ map LengthMap {

@error("client")
structure ErrorWithLengthStringMessage {
// TODO Doesn't work yet because constrained string types don't implement
// `AsRef<str>`.
// @required
// message: LengthString
@required
message: LengthString
}

map MapOfMapOfListOfListOfConB {
Expand Down
7 changes: 7 additions & 0 deletions tools/sdk-lints/src/todos.rs
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,13 @@ impl Lint for TodosHaveContext {
extension
.map(|ext| {
ext.eq_ignore_ascii_case("rs")
|| ext.eq_ignore_ascii_case("toml")
|| ext.eq_ignore_ascii_case("txt")
// TODO(https://github.com/awslabs/smithy-rs/issues/2077)
// || ext.eq_ignore_ascii_case("md")
|| ext.eq_ignore_ascii_case("sh")
|| ext.eq_ignore_ascii_case("py")
|| ext.eq_ignore_ascii_case("smithy")
|| ext.eq_ignore_ascii_case("kt")
|| ext.eq_ignore_ascii_case("kts")
})
Expand Down

0 comments on commit 30c6828

Please sign in to comment.