Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segmentation fault (core dumped) for zero length reads #26

Closed
y9c opened this issue Feb 22, 2022 · 9 comments
Closed

Segmentation fault (core dumped) for zero length reads #26

y9c opened this issue Feb 22, 2022 · 9 comments
Assignees
Labels
bug Something isn't working

Comments

@y9c
Copy link
Contributor

y9c commented Feb 22, 2022

After trimming, some reads might be 0 in length. falco can not deal with these reads correctly.

@guilhermesena1 guilhermesena1 self-assigned this Mar 4, 2022
@guilhermesena1 guilhermesena1 added the bug Something isn't working label Mar 4, 2022
dlaehnemann added a commit to hzi-bifo/phylogeny-of-single-cells that referenced this issue Mar 16, 2022
@guilhermesena1
Copy link
Collaborator

guilhermesena1 commented Mar 22, 2022

I'm so sorry it took this long to reach out but I think I fixed the problem. I'll make a new release in the coming days to address this. Commit 64d98db should not crash on empty reads. Definitely a very important bug to address!

@y9c
Copy link
Contributor Author

y9c commented Mar 23, 2022

Thanks!

@y9c
Copy link
Contributor Author

y9c commented Mar 23, 2022

Hi @guilhermesena1,

The new patch create more bugs. When there is a empty read, falco will keep running, but it can not generate any output, and terminate with the following error.

 terminate called after throwing an instance of 'std::bad_alloc'
  what():  std::bad_alloc
[1]    3085727 abort (core dumped)  falco ./test.fq.gz -o test

@y9c
Copy link
Contributor Author

y9c commented Mar 23, 2022

This error is not cause by zero length reads. Any fastq input can cause this error. If html output is skip, everything works fine.


I compile the code with autoreconf command, then it works.

@y9c
Copy link
Contributor Author

y9c commented Mar 23, 2022

I would like to know why zero length reads is not in the "Sequence Length Distribution" plot? Thanks.

@guilhermesena1
Copy link
Collaborator

hey.

for the first error, I think your call has reversed the parameters. Falco takes multiple FASTQC as inputs, and this requires the file names to be the last parameters in the call, so instead of

falco test.fq.gz -o test

it should be

falco -o test test.fq.gz

I'll look into the plot issue right now.

@guilhermesena1
Copy link
Collaborator

ok the plot issue should be fixed at 0523ad9

@y9c
Copy link
Contributor Author

y9c commented Mar 23, 2022

Thank you for the update

@y9c
Copy link
Contributor Author

y9c commented Mar 29, 2022

Hi @guilhermesena1

It seem that falco is still have bugs in dealing short reads. When input reads are too short, the html report can not be generated.

Error message:

terminate called after throwing an instance of 'std::length_error'

test input:

@test
TTACAGCACT
+
FFFFFFFFFF

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants