Missed the setindex bugfix

smillerc · Sep 28, 2022 · a5bff72 · a5bff72 · smillerc · Sep 28, 2022
1 parent f1d6e71
commit a5bff72
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,7 +1,7 @@
 name = "BlockHaloArrays"
 uuid = "8029ca6b-11ad-4a59-88a2-2e6eee4ef8a2"
 authors = ["Sam Miller <[email protected]> and contributors"]
-version = "0.4.2"
+version = "0.4.3"
 
 [deps]
 EllipsisNotation = "da5c29d0-fa7d-589e-88eb-ea29b0a81949"

diff --git a/src/indexing.jl b/src/indexing.jl
@@ -86,7 +86,7 @@ since the actual data within the BlockHaloArray is a series of separate blocks.
 the array in this manner will be slower due to the additional arithmetic needed to find the global
 to local index conversion for each block.
 """
-function Base.setindex!(A::BlockHaloArray, v, global_idx::Vararg{Int,N}) where {N}
+function Base.setindex!(A::BlockHaloArray, v, global_idx::NTuple{N,Int}) where {N}
     block_idx = ntuple(i ->
             get_block_idx(global_idx[A.halodims[i]],
                 A._cummulative_blocksize_per_dim,

diff --git a/test/unit/test_util_funcs.jl b/test/unit/test_util_funcs.jl
@@ -87,6 +87,7 @@ end
     A = BlockHaloArray(x, nhalo, nblocks)
 
     @test all(A[1] .== A.blocks[1])
+    @test_nowarn A[4] .= 2.5
 end
 
 @testitem "n-D Indexing" begin
@@ -104,7 +105,9 @@ end
     @test A[1] == A.blocks[1]
     @test size(A[1]) == (24, 24)
     @test A[1][3,3] == x[1,1]
-
+    @test_nowarn A[1][3,3] = 1.2
+
     @test B[1][1,3,3] == y[1,1,1]
     @test B[1][:,3,3] == y[:,1,1]
+    @test_nowarn B[1][1,3,3] =6.7
 end