SKS-1825: Remove the verification that IP must have a gateway #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #36 +/- ##
==========================================
+ Coverage 67.53% 68.40% +0.87%
==========================================
Files 2 2
Lines 308 307 -1
==========================================
+ Hits 208 210 +2
+ Misses 84 81 -3
Partials 16 16 ☔ View full report in Codecov by Sentry. |
jessehu
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
ZBS CSI 的 IP Pool 可以不设置 gateway。
当前 IP Pool 没有校验是否设置了 gateway，但在分配 IP 后会校验是否有 gateway。
Change
移除分配 IP 后必须有 gateway 的校验。
Test