Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Currency manager backend: enhance confusing UI #580

Closed
muratcakir opened this issue Dec 14, 2022 · 1 comment
Closed

Currency manager backend: enhance confusing UI #580

muratcakir opened this issue Dec 14, 2022 · 1 comment
Assignees
@mgesing
Labels
ui
Milestone
5.1.0

Comments

@muratcakir
Copy link
Contributor

  • Separate Live currency rates from list
  • Remove the Get live rates button in header
  • Save all rates in cache once fetched (don't fetch live on every load)
  • Reload rates only if refresh is performed explicitly
@muratcakir muratcakir added the ui label Dec 14, 2022
@muratcakir muratcakir added this to the 5.1.0 milestone Dec 14, 2022
@muratcakir muratcakir assigned mgesing and unassigned Michael-Herzog Jul 8, 2023
@mgesing
Copy link
Contributor

mgesing commented Jul 11, 2023 •
edited
Loading

Separate Live currency rates from list

What exactly is meant by this? Why to separate? Should the live currency rates be moved to somewhere else? Doesn't make sense to me to separate anything here.

I would combine everything into one currency grid with two columns applied rate and live rate.

mgesing added a commit that referenced this issue Jul 12, 2023
@mgesing
#580 Added caching for live currency exchange rates.
fd5d836 
Perf: avoid RegionInfo(int) constructor (brutally slow).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mgesing mgesing

Labels
ui
Projects
None yet
Milestone
5.1.0
Development

No branches or pull requests
3 participants
@muratcakir @mgesing @Michael-Herzog