Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Part 4 of unit test coverage + tiny readme update to add developer agreement link #74

Merged
merged 5 commits into from
Oct 28, 2023
Merged

Part 4 of unit test coverage + tiny readme update to add developer agreement link #74

merged 5 commits into from
Oct 28, 2023

Conversation

priyankalakhe
Copy link
Contributor

@priyankalakhe priyankalakhe commented Oct 27, 2023 •
edited
Loading

Description of changes

@priyankalakhe priyankalakhe mentioned this pull request Oct 27, 2023
Closed
@priyankalakhe priyankalakhe changed the title Unit test coverage + tiny readme update to add developer agreement link Part 4 of unit test coverage + tiny readme update to add developer agreement link Oct 27, 2023
@priyankalakhe priyankalakhe marked this pull request as ready for review October 28, 2023 00:45
zromano
zromano previously approved these changes Oct 28, 2023
View reviewed changes
Copy link
Contributor

@zromano zromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it. Thanks for doing this

src/test/java/com/smartsheet/api/internal/SightResourcesImplTest.java Outdated Show resolved Hide resolved
src/test/java/com/smartsheet/api/internal/SightResourcesImplTest.java Show resolved Hide resolved
src/test/java/com/smartsheet/api/internal/UserResourcesImplTest.java Outdated Show resolved Hide resolved
src/test/java/com/smartsheet/api/internal/UserResourcesImplTest.java Outdated Show resolved Hide resolved
@priyankalakhe priyankalakhe merged commit 7a02db8 into mainline Oct 28, 2023
1 check passed
@priyankalakhe priyankalakhe deleted the personal/plakhe/unit-test-coverage branch October 28, 2023 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zromano zromano zromano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@priyankalakhe @zromano