Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create GridSearchCV #180

Merged
merged 1 commit into from
Oct 1, 2022

Conversation

morenol
Copy link
Collaborator

@morenol morenol commented Oct 1, 2022

A little bit of refactoring of the search_grid module to add the GridSearchCV with a similar shape to https://scikit-learn.org/stable/modules/generated/sklearn.model_selection.GridSearchCV.html#

@montanalow please let me know if this sounds good to you. I would love to have this merged before addressing #169

@morenol morenol changed the title feat: Create SearchGridCV feat: Create GridSearchCV Oct 1, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #180 (06f261f) into development (3c62686) will decrease coverage by 0.07%.
The diff coverage is 75.55%.

@@               Coverage Diff               @@
##           development     #180      +/-   ##
===============================================
- Coverage        84.64%   84.56%   -0.08%     
===============================================
  Files               86       86              
  Lines             9948     9974      +26     
===============================================
+ Hits              8420     8435      +15     
- Misses            1528     1539      +11     
Impacted Files Coverage Δ
src/model_selection/mod.rs 94.04% <ø> (ø)
src/model_selection/hyper_tuning/grid_search.rs 77.55% <75.55%> (-5.06%) ⬇️
src/optimization/line_search.rs 82.00% <0.00%> (-8.00%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@montanalow montanalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consistency makes sense. Looks good to me.

@morenol morenol merged commit f8210d0 into smartcorelib:development Oct 1, 2022
@morenol morenol deleted the lmm/grid_search branch October 1, 2022 21:44
morenol added a commit that referenced this pull request Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants