Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Ethers.JS version used by view-function EAs #3456

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

alecgard
Copy link
Contributor

@alecgard alecgard commented Oct 7, 2024

Testing

  • Tested with the below query, that incudes the override keyword in the function signature
curl --location 'localhost:8080' \ --header 'Content-Type: application/json' \ --data '{ "data": { "address": "0x9ba021b0a9b958b5e75ce9f6dff97c7ee52cb3e6", "function": "function previewRedeem(uint256 shares) public view override returns (uint256)", "inputParams": [ "1000000000000000000" ], "network": "ETHEREUM" } }''
  • Before the fix, the EA would spam unknown modifier: override every time it fetched data. Post-fix, log spam is gone and EA continues to serve data.
  • Had to update the fixtures in our integration tests, as the upgraded ethers.js defaults to using JSON-RPC batch requests

Copy link

changeset-bot bot commented Oct 7, 2024

🦋 Changeset detected

Latest commit: 7d39b3d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@chainlink/view-function-multi-chain-adapter Minor
@chainlink/view-function-adapter Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@alecgard alecgard force-pushed the feat/view-function-upgrade-ethers branch from 9ef1a0c to 7d39b3d Compare October 7, 2024 13:51
@alecgard alecgard marked this pull request as ready for review October 7, 2024 13:55
@alecgard alecgard requested a review from a team October 7, 2024 13:58
@alecgard alecgard merged commit 62ba1ac into main Oct 7, 2024
8 checks passed
@alecgard alecgard deleted the feat/view-function-upgrade-ethers branch October 7, 2024 15:16
@github-actions github-actions bot mentioned this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants