Delete bridges from the UI #4046
Conversation
jkongie
commented
Mar 9, 2021
•
jkongie
commented
- Replaces loading data using redux with hooks in Bridges#Show
- Adds table row clicking to the Bridges List
- Display the Bridge data in a table format for improved readability
- Add a button to delete a bridge on the Bridges#Show page
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
jkongie
force-pushed
the
feature-176137722/delete-bridge-from-ui
branch
from
1f37025
to
a9e0956
Compare
jkongie
force-pushed
the
feature-176137722/delete-bridge-from-ui
branch
from
7c0a5e2
to
19e7d2f
Compare
| // Contains styles to make a table row linkable | ||
| // | ||
| // This has been placed in the components folder because we ideally want to | ||
| // wrap the link in a reusable components, however using Material UI 3 | ||
| // 'withStyles' leads to small freeze when navigating to the link, due to | ||
| // the slowness of JSS. When we migrate to MUI 4/5 we can implement this with | ||
| // makeStyles which doesn't have those problems |
There was a problem hiding this comment.
You could also use a regular style objects instead of createStyles?
There was a problem hiding this comment.
I was attempting to attempting to customise the TableRow itself using this HOC technique
https://v3.material-ui.com/customization/overrides/#shorthand
However the problem can be found I found was that it spends too much time in JSS.
mui/material-ui#10778 (comment)
I could use styles to do it, but I'm hoping we can upgrade this to MUI v4 soon, and then make the improvement.
| const mockHistoryPush = jest.fn() | ||
| jest.mock('react-router-dom', () => ({ | ||
| ...(jest.requireActual('react-router-dom') as typeof ReactRouterDom), | ||
| useHistory: () => ({ | ||
| push: mockHistoryPush, | ||
| }), | ||
| })) |
There was a problem hiding this comment.
Why do you need to mock it? Because we are using a memory router in mountWithProviders it should be perfectly fine to simply inspect the location without having to mock react-router-dom
There was a problem hiding this comment.
Great! Thanks for the tip
I've removed the mock and added the location check
* Replaces loading data using redux with hooks in Bridges#Show * Adds table row clicking to the Bridges List * Display the Bridge data in a table format for improved readability https://www.pivotaltracker.com/story/show/176137722
jkongie
force-pushed
the
feature-176137722/delete-bridge-from-ui
branch
from
19e7d2f
to
8eb62cb
Compare
