Custom Fallback TOML Config #15617
Open
Custom Fallback TOML Config #15617
+200
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see you updated files related to
|
| // fallback.toml(defaults dir) <- fallback.toml(env CL_CHAIN_FALLBACK) <- ChainSpecific.toml(env CL_CHAIN_DEFAULTS) | ||
| // | ||
| // the custom fallback gets processed and overrides the default fallback | ||
| if path := env.CustomFallback.Get(); path != "" { |
There was a problem hiding this comment.
can we lock this in with a testscripts test like in https://github.com/smartcontractkit/chainlink/pull/14090/files#diff-ea10429fdb1fbc100e3d8082e39e6d40a12f82b48c1f37ab9158b6c3c0e44d81 ?
There was a problem hiding this comment.
Good idea. I'll add that
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
This commit provides setting a new env var `CL_CHAIN_FALLBACK` as a path to a custom `fallback.toml`. This allows plugins to define their own set of fallback options apart from the core node which override the default fallback options.
EasterTheBunny
force-pushed
the
etb/toml-custom-fallback
branch
from
1d753ac to
436023c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit provides setting a new env var
CL_CHAIN_FALLBACKas a path to a customfallback.toml. This allows plugins to define their own set of fallback options apart from the core node which override the default fallback options.CCIP-4395