Increase default timeout of remote Executable requests #15587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see you updated files related to
|
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
bolekk
force-pushed
the
remote_timeout
branch
from
b89c452 to
07a693e
Compare
krehermann
reviewed
Dec 10, 2024
core/capabilities/launcher.go
Outdated
| @@ -398,7 +398,8 @@ func (w *launcher) addToRegistryAndSetDispatcher(ctx context.Context, capability | |||
| } | |||
|
|
|||
| var ( | |||
| defaultTargetRequestTimeout = time.Minute | |||
| // TODO: make this configurable | |||
| defaultTargetRequestTimeout = 10 * time.Minute | |||
There was a problem hiding this comment.
what does this mean?
if we are writing reports on aptos at up to once every 5 seconds, how can there be a 10 minute timeout in system?
There was a problem hiding this comment.
added PR description
bolekk
force-pushed
the
remote_timeout
branch
from
07a693e to
ff4ac07
Compare
bolekk
force-pushed
the
remote_timeout
branch
from
ff4ac07 to
fc546f0
Compare
cedric-cordenier
approved these changes
Dec 10, 2024
krehermann
approved these changes
Dec 10, 2024
bolekk
added a commit
that referenced
this pull request
Dec 10, 2024
bolekk
added a commit
that referenced
this pull request
Dec 10, 2024
…anch Increase default timeout of remote Executable requests (#15587)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remote Target executions are based on deltaStage parameter specified in the workflow spec.
Target capability nodes (e.g. chain writers) are invoked one-by-one with deltaStage seconds between invocations.
This timeout is the maximum total time all target invocations can take.
For example, with the old one minute setting, and a workflow using deltaStage=45sec, the invocations will look as follows:
Workflow Engine requires F+1 target executions to complete successfully. When F=5, and timeout set to 1 min, it never has a chance to do so.
Bumping to a larger value, which is closer to max workflow execution time (10 mins). Should give us plenty of headroom for DONs with F=5 and deltaStage up to 1 min.