Refactoring and improvements around token transfer and usdc transfer tests #15502
+308
−190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateusz-sekara
changed the title
mateusz-sekara
requested review from
winder,
rstout,
asoliman92,
makramkd,
dimkouv,
0xAustinWang and
0xnogo
AnieeG
reviewed
Dec 4, 2024
| } | ||
| }) | ||
| } | ||
| execStates := changeset.ConfirmExecWithSeqNrsForAll( |
There was a problem hiding this comment.
are parallel checks not applicable here like you did for commit?
| ) { | ||
| errGrp := &errgroup.Group{} | ||
| for chainID, tokens := range expectedBalances { | ||
| for id, balance := range tokens { |
There was a problem hiding this comment.
better to create local scope for id and balance here
| errGrp := &errgroup.Group{} | ||
|
|
||
| for sourceDest, seqRange := range expectedSeqNums { | ||
| errGrp.Go(func() error { |
There was a problem hiding this comment.
might run into overrides, better to create local scope for sourceDest and seqRange
|
|
||
| for _, tt := range requests { | ||
| t.Run(tt.Name, func(t *testing.T) { | ||
| expectedTokenBalances = AppendExpectedTokenBalances( |
There was a problem hiding this comment.
is it possible to run these in parallel?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires
Supports