CCIP-4163 Out of order execution #15489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateusz-sekara
requested review from
winder,
rstout,
asoliman92,
makramkd,
dimkouv,
0xAustinWang and
0xnogo
dimkouv
reviewed
Dec 3, 2024
| Status: "complete", | ||
| Attestation: "0x9049623e91719ef2aa63c55f357be2529b0e7122ae552c18aff8db58b4633c4d3920ff03d3a6d1ddf11f06bf64d7fd60d45447ac81f527ba628877dc5ca759651b08ffae25a6d3b1411749765244f0a1c131cbfe04430d687a2e12fd9d2e6dc08e118ad95d94ad832332cf3c4f7a4f3da0baa803b7be024b02db81951c0f0714de1b", | ||
| } | ||
| if isFaulty { | ||
| response = attestationStatusResponse{ |
There was a problem hiding this comment.
you could re-use this struct in the mock responses you generate above.
response = `{
"status": "pending",
"error": "internal error"
}`
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
mateusz-sekara
force-pushed
the
out-of-order-exec-tests
branch
from
4689c3d
to
7529591
Compare
mateusz-sekara
commented
Dec 3, 2024
mateusz-sekara
force-pushed
the
out-of-order-exec-tests
branch
from
aabefd5
to
a4935d2
Compare
lukaszcl
previously approved these changes
Dec 3, 2024
b-gopalswami
reviewed
Dec 3, 2024
asoliman92
reviewed
Dec 3, 2024
asoliman92
reviewed
Dec 3, 2024
asoliman92
reviewed
Dec 3, 2024
mateusz-sekara
commented
Dec 4, 2024
| sourceChain uint64, | ||
| e deployment.Environment, | ||
| ) (*bind.TransactOpts, error) { | ||
| for _, user := range tenv.Users[sourceChain] { |
There was a problem hiding this comment.
@AnieeG for some reason first 10 senders were... empty, just nils. I couldn't just pick the first one, but instead have this loop looking for the first one that is not nill and different than deployer
There was a problem hiding this comment.
should be fixed here - #15506
dimkouv
approved these changes
Dec 4, 2024
lukaszcl
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires
Supports