CCIP-4303:Enabling in-memory test in integration-tests workflow #15388
Conversation
b-gopalswami
requested review from
winder,
rstout,
asoliman92,
makramkd,
dimkouv,
mateusz-sekara and
0xAustinWang
| @@ -18,8 +17,7 @@ import ( | |||
|
|
|||
| func TestInitialDeployOnLocal(t *testing.T) { | |||
| t.Parallel() | |||
| lggr := logger.TestLogger(t) | |||
| tenv, _, _ := testsetups.NewLocalDevEnvironmentWithDefaultPrice(t, lggr, nil) | |||
| tenv := changeset.NewMemoryEnvironmentWithJobsAndContracts(t, logger.TestLogger(t), 2, 4, nil) | |||
There was a problem hiding this comment.
not the best test to convert, may be try with fee boosting test. that has the longest running time. This one is just a basic test and should stay in docker. We already have a similar test in memory
There was a problem hiding this comment.
Also I see the runtime is not improved much( it's > 9min) in CI any idea why?
There was a problem hiding this comment.
This is just an example to prove it works. Instead of we convert some test to in-memory, we will eventually add in-memory tests like the one @asoliman92 wants to add for ccipreader.
The other test still runs for 350+ secs. This one previously ran for ~320 secs and now it is ~85 secs. So, clubbing in-memory and docker test might not be helpful. We should have in-memory tests as separate matrix.
Adding postgres instance to integration_tests workflow and converted one test from docker to in-memory test.
If any new in-memory tests gets added, pass PG_INSTANCE test_env_vars as true.