[KS-490] Support per-step timeout overrides in the Engine #15367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see you updated files related to
|
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
bolekk
force-pushed
the
timeout_fix
branch
2 times, most recently
from
2136235
to
900c3c4
Compare
krehermann
approved these changes
Nov 21, 2024
| @@ -27,7 +27,11 @@ import ( | |||
| "github.com/smartcontractkit/chainlink/v2/core/services/workflows/store" | |||
| ) | |||
|
|
|||
| const fifteenMinutesMs = 15 * 60 * 1000 | |||
| const ( | |||
| fifteenMinutesMs = 15 * 60 * 1000 | |||
There was a problem hiding this comment.
use time.Duration to avoid an ambiguity?
There was a problem hiding this comment.
Yeah let's please use time.Duration wherever we can :)
There was a problem hiding this comment.
The tradeoff is you cant use const as the time.Duration methods are runtime only
| @@ -934,8 +949,11 @@ func (e *Engine) executeStep(ctx context.Context, lggr logger.Logger, msg stepRe | |||
| }, | |||
| } | |||
|
|
|||
| e.metrics.incrementCapabilityInvocationCounter(ctx) | |||
| output, err := step.capability.Execute(ctx, tr) | |||
There was a problem hiding this comment.
Execute is syncronous, so this should not be a problem?
cedric-cordenier
approved these changes
Nov 21, 2024
Comment on lines
+30
to
+34
| const ( | ||
| fifteenMinutesMs = 15 * 60 * 1000 | ||
| reservedFieldNameStepTimeout = "cre_step_timeout" | ||
| maxStepTimeoutOverrideSec = 10 * 60 // 10 minutes | ||
| ) |
There was a problem hiding this comment.
Suggested change
| const ( | |
| fifteenMinutesMs = 15 * 60 * 1000 | |
| reservedFieldNameStepTimeout = "cre_step_timeout" | |
| maxStepTimeoutOverrideSec = 10 * 60 // 10 minutes | |
| ) | |
| var ( | |
| fifteenMinutesMs = 15 * time.Minute.Milliseconds() | |
| reservedFieldNameStepTimeout = "cre_step_timeout" | |
| maxStepTimeoutOverrideSec = 10 * time.Minute.Seconds() | |
| ) |
| @@ -919,6 +920,20 @@ func (e *Engine) executeStep(ctx context.Context, lggr logger.Logger, msg stepRe | |||
| if err != nil { | |||
| return nil, nil, err | |||
| } | |||
| stepTimeoutDuration := e.stepTimeoutDuration | |||
| if timeoutOverride, ok := config.Underlying[reservedFieldNameStepTimeout]; ok { | |||
There was a problem hiding this comment.
is this config set per capability? Checking to make sure its not set at the workflow level
There was a problem hiding this comment.
Yes, see example in the test file
patrickhuie19
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.