remove dependency of postgres trigger for broadcaster #11109
Conversation
|
I see that you haven't updated any README files. Would it make sense to do so? |
poopoothegorilla
requested review from
patrick-dowell,
mohamed-mehany,
prashantkumar1982 and
amit-momin
There was a problem hiding this comment.
It's awesome this PR cleans up so much code!
I'm not sure exactly what's going on with the switch from pkg/errors.wrap to fmt.Errorf. I assume it's related to the overall change in error changing cause by the removal of the trigger dependency, but I don't entirely understand it.
| @@ -223,8 +222,10 @@ func (b *Txm[CHAIN_ID, HEAD, ADDR, TX_HASH, BLOCK_HASH, R, SEQ, FEE]) Reset(addr | |||
| func (b *Txm[CHAIN_ID, HEAD, ADDR, TX_HASH, BLOCK_HASH, R, SEQ, FEE]) abandon(addr ADDR) (err error) { | |||
| ctx, cancel := utils.StopChan(b.chStop).NewCtx() | |||
| defer cancel() | |||
| err = b.txStore.Abandon(ctx, b.chainID, addr) | |||
| return pkgerrors.Wrapf(err, "abandon failed to update txes for key %s", addr.String()) | |||
| if err = b.txStore.Abandon(ctx, b.chainID, addr); err != nil { | |||
There was a problem hiding this comment.
is it a common go pattern to do the assignment and comparison this way?
There was a problem hiding this comment.
I typically am a fan of doing it this way to prevent accidental overshadowing of the error... i have witnessed bugs in the past where the error does not get fully handled and gets overwritten accidentally. scoping it this way reduces the chances of that happening slightly
| } | ||
|
|
||
| // Trigger the Broadcaster to check for new transaction | ||
| b.broadcaster.Trigger(txRequest.FromAddress) |
There was a problem hiding this comment.
love to see how simple this now is!
|
SonarQube Quality Gate
|
Notes: