-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Foundry persistence - dump foundry state in an interval of 10s #945
Conversation
- "--state-interval" | ||
- "10" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the data dump happens on the intervals and is not in the a realtime, maybe it would be better to push this to S3. How large is the data dump?
Does 10
means, dump data every 10 seconds?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes right ! it dumps every 10s to the file location specified in --state
args and during start up it loads from that file if the file exists
I'm approving this PR to unblock our current test suite, however, we need to find a solution to use |
charts/foundry/values.yaml
Outdated
runAsNonRoot: true | ||
# foundry user/group | ||
runAsUser: 1000 | ||
runAsGroup: 1000 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
try adding fsGroup: 1000
here I think that should help to make the volume writable from non root user
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quality Gate passedIssues Measures |
Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.
Why
The update introduces persistent storage for Foundry, enhancing data persistence capabilities. It adjusts the deployment configuration to support state dumping and recovery, ensuring greater resilience and continuity for blockchain simulations.
What
charts/foundry/Chart.yaml
charts/foundry/templates/deployment.yaml
state-storage
to the deployment to support the persistence of the blockchain state.state-storage
with a persistent volume claim (PVC) for storing the blockchain state.charts/foundry/templates/pvc.yaml
charts/foundry/values.yaml
capacity
andstorageClassName
keys to allow configuration of the persistent volume size and class.volumeMounts
to include mounting for the new persistent storage, specifying the mount path and volume name.