-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add code generators to help build workflows #704
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolag
force-pushed
the
rtinianov_builders
branch
from
August 14, 2024 14:49
3ab8678
to
16b6be2
Compare
nolag
force-pushed
the
rtinianov_builders
branch
from
August 14, 2024 15:22
16b6be2
to
82d4134
Compare
DeividasK
reviewed
Aug 14, 2024
It might make sense to have tests for the generators so the edge cases are covered (I'm not sure if you plan to do a builder for every possible combination). |
nolag
force-pushed
the
rtinianov_builders
branch
from
August 15, 2024 15:23
82d4134
to
7033852
Compare
nolag
force-pushed
the
rtinianov_builders
branch
from
August 15, 2024 15:26
7033852
to
f25b161
Compare
nolag
force-pushed
the
rtinianov_builders
branch
from
August 15, 2024 15:29
f25b161
to
3056793
Compare
nolag
force-pushed
the
rtinianov_builders
branch
from
August 15, 2024 15:32
3056793
to
c060deb
Compare
nolag
force-pushed
the
rtinianov_builders
branch
from
August 19, 2024 18:20
438c135
to
586964f
Compare
jmank88
approved these changes
Aug 19, 2024
DeividasK
reviewed
Aug 20, 2024
DeividasK
approved these changes
Aug 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving on the assumption that you'll add a test in a follow-up PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last part taken from this PR