Skip to content

Commit

Permalink
Update smartrtbBidAdapter (prebid#4362)
Browse files Browse the repository at this point in the history
* modules: Implement SmartRTB adapter and spec.

* Fix for-loop syntax to support IE; refactor getDomain out of exported set.

* Remove debugs, update doc

* Update test for video support

* Handle missing syncs. Add video to media types in sample ad unit

* Add null response check, update primary endpoint

* Note smrtb video requires renderer

* Remove old params checks, fix documentation playerSize field name
  • Loading branch information
evanmsmrtb authored and tadam75 committed Jan 9, 2020
1 parent 9ca98e7 commit 3eecdce
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
5 changes: 1 addition & 4 deletions modules/smartrtbBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,8 @@ function getDomain () {
export const spec = {
code: BIDDER_CODE,
supportedMediaTypes: [ 'banner', 'video' ],
aliases: ['smrtb'],
isBidRequestValid: function(bid) {
return (bid.params.pubId !== null &&
bid.params.medId !== null &&
bid.params.zoneId !== null);
return (bid.params.zoneId !== null);
},
buildRequests: function(validBidRequests, bidderRequest) {
let stack = (bidderRequest.refererInfo &&
Expand Down
2 changes: 1 addition & 1 deletion modules/smartrtbBidAdapter.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ Video is supported but requires a publisher supplied adunit renderer at this tim
},
video: { /* requires publisher supplied renderer */
context: 'outstream',
playerDimension: [640, 480]
playerSize: [640, 480]
}
},
bids: [
Expand Down

0 comments on commit 3eecdce

Please sign in to comment.