Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds status to study tables #31

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Adds status to study tables #31

merged 1 commit into from
Oct 23, 2023

Conversation

dogversioning
Copy link
Contributor

  • Adds encounter status to study setup tables
  • cuts over to encounter display for some counts
  • renames nlp table to be explicit about contents and not collide with reserved namespace

Checklist

  • Consider if documentation (like in docs/) needs to be updated
  • Consider if tests should be added
  • Run pylint if you're making changes beyond adding studies

from_table = self.get_table_name("symptom_nlp")
from_table = self.get_table_name("symptom_ctakes_negation")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thinking nit: I'm not opposed to our strategy here. And I assume you already thought about this, but just to get my hand on the ball too - is this a signal that we are being too strict? If we don't think so but still expect someone to run into this issue, then maybe it's a signal to double-confirm that our error message about using reserved words is clear and helpful.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so - here's my thought:

  • This predates reserved words, so, I think this is sort of to be expected
  • If you created a new table now, the error message you got would be explicit about why the table creation was rejected
  • I think this table name is too generic, especially now that we're talking about potentially revisiting in the future with other nlp/llm technologies. I think it's better to be explicit about what kind of NLP tasks you did to get the results you got.

@dogversioning dogversioning merged commit 659aa62 into main Oct 23, 2023
2 checks passed
@dogversioning dogversioning deleted the mg/add_status branch October 23, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants