Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Couple of fixes #83

Merged
merged 4 commits into from
Jul 16, 2024
Merged

Couple of fixes #83

merged 4 commits into from
Jul 16, 2024

Conversation

RileyMShea
Copy link
Contributor

@RileyMShea RileyMShea commented Nov 11, 2019

Fixes: #72
Fixes: #87

Before this change the flask example would fail
to run.  The old beaker version listed in
requirements was from before python 3.6, and was
broken due to using `async` as a variable.

After this change the Flask example is closer to
being in a working state.
Before this change the example in the README.md
referenced an old defunct endpoint and patient.  This caused the
example to fail.

After this change, the example in the README works.
Copy link
Contributor

@mikix mikix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

At this point, we should probably use an r4 URL instead of r3, but this gets us functional again - we can improve it for modern FHIR later.

@mikix mikix merged commit 5d74f03 into smart-on-fhir:main Jul 16, 2024
5 checks passed
@mikix mikix mentioned this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Demo example in the README doesn't work SyntaxError: invalid syntax in /beaker/synchronization.py
2 participants