Address dependabot errors from demo server #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikix
reviewed
Jul 16, 2024
flask_app.py
Outdated
Comment on lines
13
to
14
| # TODO: CapabilityStatement.rest.resource.search.param needs to provide | ||
| # a required value type - config issue on our end for now |
There was a problem hiding this comment.
What does this mean practically - is using flask still busted, but the url change gets us further? Or is this like a nice to have later?
There was a problem hiding this comment.
The old server this was pointed at no longer exists. The newer URL is the target we are looking at, but one of the searchparams it returns is missing a required field. Once that is fixed, this should work in the default config.
I've tested against HAPI's FHIR server, which works when that server is responding, but it's latency is pretty high, so I think fixing the one we control is preferrable.
dogversioning
force-pushed
the
mg/server-dependabot
branch
from
a1400ac
to
70b13bf
Compare
mikix
approved these changes
Jul 16, 2024
|
I didn't do an exhaustive look, but this would fix #29 at least |
This was referenced Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uprevs several packages in the flask server to reduce dependabot alarms. It also updates the URL to be used as a testbed.