Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reauthorization to work beyond the first time called #127

Closed
wants to merge 1 commit into from

Conversation

timharsch
Copy link
Contributor

Address issue in #112

Copy link
Collaborator

@ducu ducu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok thank you

@ducu ducu marked this pull request as draft September 13, 2022 08:50
@ducu
Copy link
Collaborator

ducu commented Sep 13, 2022

Please pull from upstream first, your branch is behind:

This branch is 1 commit ahead, 71 commits behind smart-on-fhir:master.

@timharsch
Copy link
Contributor Author

The branch being out of date goes back to the issue #112. I still don't know what is expected here:

In our case we only use the DSTU2 version of client-py and I don't see anything in the CONTRIBUTING.md document about how to target PRs, so I'll just leave my solution here (which is a commit added on top on the v1.0.6 tag)

My confusion, at the moment, is with how this project releases it's code. I looked in the CONTRIBUTING.md document hoping to find an answer but it doesn't seem to be addressed. As far as I can tell, there are tags for different level of FHIR support. My code is based on the v1.0.6 tag, and since I am only concerned with DSTU2 support I can't run from master. Should I target this PR against the v1.0.6 tag? How would that even work? I can only test with DSTU2 sandboxes at the moment, so if I target another tag or master, I will not be able to test. If I bring my code current with master and target that with the PR, how would a version v.1.0.7 get released?

@ducu
Copy link
Collaborator

ducu commented Sep 14, 2022

Ah yes right, not sure how releasing was done for this project I'll look into it. Anyway this PR into master is not working.

@ducu ducu closed this Sep 14, 2022
@timharsch
Copy link
Contributor Author

I will reopen a new PR targeting master. In the future, you may leave the PR open if you wish to maintain the story, as it is possible to change the source and target branches on an open PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants