Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in lib.ts line 124 #118

Closed
chris-baumann112 opened this issue Mar 23, 2021 · 1 comment
Closed

Bug in lib.ts line 124 #118

chris-baumann112 opened this issue Mar 23, 2021 · 1 comment

Comments

@chris-baumann112
Copy link

const location = res.headers.get("location") + "";

Converts null to "null" if empty object.

if (location) {

Gets triggered because "null" is truthy.

Recommend avoiding implicit type conversion.
@dwwinters dwwinters mentioned this issue Apr 26, 2021
Closed
@dwwinters dwwinters mentioned this issue May 6, 2021
Closed
vlad-ignatov added a commit that referenced this issue Jun 1, 2021
@vlad-ignatov
Fix for #118
108c3a3
@vlad-ignatov
Copy link
Collaborator

A fix is included in 2.4.0. Feel free to re-open if you have further issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vlad-ignatov @chris-baumann112