Support JDK 10 and added testing #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- recognize Java 10 - determine Java versions unconditionally - update BD and give Java requirement as property - update docs, for Java 9/10 we’ll need Eclipse Oxygen 4.7 Signed-off-by: Stefan Marr <[email protected]>
As detailed here: https://markmail.org/thread/v3kqlmtwfsokfaod javac from JDK 10 onwards seems to have a bug in the parser. We can work around by using a class that exists instead of waiting for the annotation processor to produce it. Bug is reported as https://bugs.openjdk.java.net/browse/JDK-8200163 Signed-off-by: Stefan Marr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for JDK 10 in
build.xmland works around a JDK 10 bug (we track the bug here via #241).Because of an issue in
javac, we need to provide a concreteToArgumentsArrayFactory, which we can reference in annotations. Because of the bug,javacwould abort before generating the actual factory.