Handle method/mixin scope uniformly #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarr
added
the
enhancement
|
At first glance, it looks great - something that I can get my head around more easily. I can't get to this now sorry, but will do it on Wednesday. |
Until now, we kept mixin and method scopes separately, which does not directly represent the lexical structure and can cause confusion. With this change, scope is managed as a single chain outwards, with methods and mixins on the same chain. This change applies to LexicalScope classes as well as to the Builder classes. - add ScopeBuilder superclass for MixinBuilder and MethodBuilder - correctly determine whether scopes are immutable also for methods - added Local.isMutable() - InliningVisitor, handle case that there are no variables Signed-off-by: Stefan Marr <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, we kept mixin and method scopes separately (introduced with #112), which does not directly represent the lexical structure and can cause confusion.
With this change, scope is managed as a single chain outwards (solving #182), with methods and mixins on the same chain.
This change applies to LexicalScope classes as well as to the Builder classes.
@Richard-Roberts please test and review this carefully!
Locally, all tests seem to pass, but I expect that your Grace code is more complex, and could hit other issues