Add tool to identify candidates for super-instructions #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarr
added
the
enhancement
Repository owner
deleted a comment
Oct 17, 2017
Repository owner
deleted a comment
Oct 17, 2017
Repository owner
deleted a comment
Oct 17, 2017
Repository owner
deleted a comment
Oct 17, 2017
Repository owner
deleted a comment
Oct 17, 2017
Repository owner
deleted a comment
Oct 17, 2017
Repository owner
deleted a comment
Oct 17, 2017
smarr
commented
Oct 17, 2017
| // fetch the top CONSIDER_TOP_CONTEXTS activation contexts | ||
| // and construct a candidate for each of them. | ||
| List<ActivationContext> sorted = | ||
| contexts.keySet().stream().filter(context -> context.getNumberOfClasses() == 3) |
There was a problem hiding this comment.
@fredreichbier here I was wondering why that's a three. The comment above talks about 2, I believe.
Repository owner
deleted a comment
Oct 18, 2017
Repository owner
deleted a comment
Oct 18, 2017
Repository owner
deleted a comment
Oct 18, 2017
Repository owner
deleted a comment
Oct 18, 2017
smarr
force-pushed
the
super-instruction-detector
branch
from
cba0712
to
53561a5
Compare
Repository owner
deleted a comment
Oct 19, 2017
Repository owner
deleted a comment
Oct 19, 2017
Repository owner
deleted a comment
Oct 19, 2017
Repository owner
deleted a comment
Oct 19, 2017
- add TypeCountingNode/TypeCounter that records types - write activation patterns to a file - exclude eager nodes, and SequenceNode - try to find children type combinations. - write superinstruction report to metrics/ - update dym tests to account for AnyTag
Having it in DynamicMetrics is problematic, because DM disables a number of optimized nodes to get metrics relative to the source text. For super-instructions, we want knowledge about the actual execution behavior, and possibly even already enabled super-instructions. Thus, it’s better to have to separate tools. Signed-off-by: Stefan Marr <[email protected]>
smarr
force-pushed
the
super-instruction-detector
branch
from
53561a5
to
707d402
Compare
Repository owner
deleted a comment
Dec 22, 2017
Repository owner
deleted a comment
Dec 22, 2017
Repository owner
deleted a comment
Dec 22, 2017
Repository owner
deleted a comment
Dec 22, 2017
Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
This can happen, when there are fewer context levels than requested. Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
- make some fields final Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
…rn out to be equivalent Signed-off-by: Stefan Marr <[email protected]>
smarr
force-pushed
the
super-instruction-detector
branch
from
5586bf9
to
14aa09a
Compare
|
This PR was blocked by failing tests on Linux. Cutting off at that point could result in slightly different reports being generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new Truffle tool to instrument all nodes, track their execution, and determine node configurations that are frequently used together.
These node configurations might benefit from being converted into a single node that reduces the interpretation overhead.
This is work by @fredreichbier.
@fredreichbier, could you please review the PR, and check whether everything looks ok for you?
This is a first version, I might still do some more cosmetic changes.