-
-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable nested translations #648
Enable nested translations #648
Conversation
File size impactMerging feat/nested_translations into develop impact files as follow: empty-piral (no impact)
minimal-piral (no impact)
sample-cross-fx (no impact)
sample-piral (+0.24%)
sample-piral-core (no impact)
|
14d41b4
to
fad0768
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general looks good to me (thanks for the PR!), however, we might be able to circumvent the getValue
call / dependency by just flattening the input object (see comment). What do you think?
444f51a
to
fad0768
Compare
cee9c8e
to
5d82381
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks!
New Pull Request
For more information, see the
CONTRIBUTING
guide.Prerequisites
Please make sure you can check the following boxes:
Type(s) of Changes
Contribution Type
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Description
This pull request enables the use of nested translations:
Before
After
Remarks
-