Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix codegen'd import statements in Windows environments #620

Merged
merged 5 commits into from
Aug 23, 2023

Conversation

peter-at-work
Copy link
Contributor

New Pull Request

For more information, see the CONTRIBUTING guide.

Prerequisites

Please make sure you can check the following boxes:

  • I have read the CONTRIBUTING document
  • My code follows the code style of this project
  • All new and existing tests passed

Type(s) of Changes

Contribution Type

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue, please reference the issue id)
  • New feature (non-breaking change which adds functionality, make sure to open an associated issue first)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • I have updated the documentation accordingly
  • I have added tests to cover my changes

Description

Fixes #619

For relative paths generated from the piral-core codegen module, they are to be used in codegen'd import statements. So the paths have to be normalized back to use posix-type slash path separators.

Remarks

The issue only appears when a piral instance is being provisioned/built in a Windows environment. Import statements should always be using the posix-style path separators.

@peter-at-work peter-at-work marked this pull request as ready for review August 22, 2023 20:47
@github-actions
Copy link

github-actions bot commented Aug 22, 2023

File size impact

Merging feature/fix-win32-codegen into develop impact files as follow:

empty-piral (no impact)
Files new size
Unmodified (2) 28.6 kB (0 B / +0%) 👻
Total (2) 28.6 kB (0 B / +0%) 👻
minimal-piral (no impact)
Files new size
Unmodified (2) 251 kB (0 B / +0%) 👻
Total (2) 251 kB (0 B / +0%) 👻
sample-cross-fx (no impact)
Files new size
Unmodified (3) 2.17 MB (0 B / +0%) 👻
Total (3) 2.17 MB (0 B / +0%) 👻
sample-piral (no impact)
Files new size
Unmodified (3) 639 kB (0 B / +0%) 👻
Total (3) 639 kB (0 B / +0%) 👻
sample-piral-core (no impact)
Files new size
Unmodified (3) 305 kB (0 B / +0%) 👻
Total (3) 305 kB (0 B / +0%) 👻
Generated by @jsenv/file-size-impact during check-bundle-size#5948332760 on 00e9864

@FlorianRappl FlorianRappl added the bug Something isn't working label Aug 23, 2023
@FlorianRappl FlorianRappl added this to the 1.2.0 milestone Aug 23, 2023
Copy link
Contributor

@FlorianRappl FlorianRappl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@FlorianRappl FlorianRappl merged commit 6b585f2 into smapiot:develop Aug 23, 2023
5 checks passed
@peter-at-work peter-at-work deleted the feature/fix-win32-codegen branch August 24, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failure to build piral instance in Windows and node18
2 participants