Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace relative path with configurable #504

Merged
merged 1 commit into from
Apr 4, 2022
Merged

replace relative path with configurable #504

merged 1 commit into from
Apr 4, 2022

Conversation

LBraeschke
Copy link
Contributor

@LBraeschke LBraeschke commented Apr 4, 2022

New Pull Request

For more information, see the CONTRIBUTING guide.

Prerequisites

Please make sure you can check the following boxes:

  • I have read the CONTRIBUTING document
  • My code follows the code style of this project
  • All new and existing tests passed

Type(s) of Changes

Contribution Type

What types of changes does your code introduce? Put an x in all the boxes that apply:

Description

Change static relative path to an configurable. By default the build step will use the path from root.

Remarks

[Optionally place any follow-up comments, remarks, observations, or notes here for future reference]

@CLAassistant
Copy link

CLAassistant commented Apr 4, 2022

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

github-actions bot commented Apr 4, 2022

File size impact

Merging hotfix/503-fix-relative-link into develop impact files as follow:

sample-cross-fx (no impact)
Files new size
Unmodified (3) 2.82 MB (0 B / +0%) 👻
Total (3) 2.82 MB (0 B / +0%) 👻
sample-piral (no impact)
Files new size
Unmodified (3) 798 kB (0 B / +0%) 👻
Total (3) 798 kB (0 B / +0%) 👻
sample-piral-core (no impact)
Files new size
Unmodified (3) 250 kB (0 B / +0%) 👻
Total (3) 250 kB (0 B / +0%) 👻
Generated by @jsenv/file-size-impact during Check bundle size#2088147518 on dc0b1df

@FlorianRappl FlorianRappl self-requested a review April 4, 2022 07:14
@FlorianRappl FlorianRappl added this to the 0.15.0 milestone Apr 4, 2022
@FlorianRappl FlorianRappl added bug Something isn't working enhancement New feature or request cli Concerns the piral-cli application. labels Apr 4, 2022
@FlorianRappl FlorianRappl changed the base branch from develop to experimental April 4, 2022 07:15
Copy link
Contributor

@FlorianRappl FlorianRappl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

🍻

@FlorianRappl FlorianRappl merged commit 7f9158d into smapiot:experimental Apr 4, 2022
@LBraeschke LBraeschke deleted the hotfix/503-fix-relative-link branch April 4, 2022 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cli Concerns the piral-cli application. enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In standalone mode the link to the pilet is pointing to an relative and not an abolut path
3 participants