Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Toggle / Disable+Enable in Debug Tools #659

Closed
FlorianRappl opened this issue Dec 14, 2023 · 0 comments
Closed

Improve Toggle / Disable+Enable in Debug Tools #659

FlorianRappl opened this issue Dec 14, 2023 · 0 comments
Labels
core Concerns the piral-core library. enhancement New feature or request
Milestone
1.4.2

Comments

@FlorianRappl
Copy link
Contributor

New Feature Proposal

For more information, see the CONTRIBUTING guide.

Description

Right now when the disable (toggle in the Piral Inspector) option is used the pilet is essentially removed, however, the full lifecycle is not run. Therefore, stylesheets are already removed (for instance), but when a pilet is enabled again the stylesheet is never re-attached. Likewise, subsequent cleanups are not run.

Background

In a demo application when toggling the stylesheet is first removed (on first disable) but never attached again, leading to a broken design.

Discussion

(nothing)
@FlorianRappl FlorianRappl added enhancement New feature or request core Concerns the piral-core library. in-review The item is currently being reviewed. labels Dec 14, 2023
@FlorianRappl FlorianRappl added this to the 1.4.2 milestone Dec 14, 2023
@FlorianRappl FlorianRappl added in-implementation The item is currently being implemented. and removed in-review The item is currently being reviewed. labels Dec 15, 2023
FlorianRappl added a commit that referenced this issue Dec 15, 2023
@FlorianRappl
Fixed issue with broken lifecycle #659
51002d7
@FlorianRappl FlorianRappl added in-testing The item is already out in preview and can be tested. and removed in-implementation The item is currently being implemented. labels Dec 15, 2023
@FlorianRappl FlorianRappl removed the in-testing The item is already out in preview and can be tested. label Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core Concerns the piral-core library. enhancement New feature or request
Projects
None yet
Milestone
1.4.2
Development

No branches or pull requests
1 participant
@FlorianRappl