Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The index.d.ts of a Pilet Is Placed In dist #658

Closed
3 tasks done
FlorianRappl opened this issue Dec 14, 2023 · 0 comments
Closed
3 tasks done

The index.d.ts of a Pilet Is Placed In dist #658

FlorianRappl opened this issue Dec 14, 2023 · 0 comments
Labels
bug Something isn't working cli Concerns the piral-cli application.
Milestone

Comments

@FlorianRappl
Copy link
Contributor

Bug Report

For more information, see the CONTRIBUTING guide.

Prerequisites

  • Can you reproduce the problem in a MWE?
  • Are you running the latest version?
  • Did you perform a search in the issues?

Environment Details and Version

Ubuntu, Piral CLI 1.4.1

Description

When a new pilet is scaffolded using npm init pilet@latest the generated (via postinstall) declaration is empty (expected) and located in the project's root folder (instead of the dist) folder. I thin this only happens on scaffolding.

Steps to Reproduce

  1. Scaffold a new pilet
  2. Look in the pilet's root folder

Expected behavior

Either nothing (since the pilet.d.ts is anyway empty) should be generated, or an empty file in the dist folder.

Actual behavior

The file is generated in the root folder.

Possible Origin/Solution

I think that the dist is not yet given as the previous "version" of the package.json did not have a proper main specified. Thus, it falls back to the root directory.

@FlorianRappl FlorianRappl added bug Something isn't working cli Concerns the piral-cli application. in-review The item is currently being reviewed. labels Dec 14, 2023
@FlorianRappl FlorianRappl added this to the 1.4.2 milestone Dec 14, 2023
@FlorianRappl FlorianRappl added in-implementation The item is currently being implemented. and removed in-review The item is currently being reviewed. labels Dec 15, 2023
@FlorianRappl FlorianRappl added in-testing The item is already out in preview and can be tested. and removed in-implementation The item is currently being implemented. in-testing The item is already out in preview and can be tested. labels Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cli Concerns the piral-cli application.
Projects
None yet
Development

No branches or pull requests

1 participant