Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check Version of Inherited Dependencies #635

Closed
FlorianRappl opened this issue Oct 17, 2023 · 0 comments
Closed

Check Version of Inherited Dependencies #635

FlorianRappl opened this issue Oct 17, 2023 · 0 comments
Labels
cli Concerns the piral-cli application. enhancement New feature or request pilets Concerns the API of the pilets.
Milestone
1.3.1

Comments

@FlorianRappl
Copy link
Contributor

New Feature Proposal

For more information, see the CONTRIBUTING guide.

Description

Inherited dependencies (via an importmap) should be checked by the pilets when commands from the piral-cli are run.

Background

Right now the CLI displays an info when an inherited dependency is unused / not installed. This is fine, but we should also go one step further - what if we installed a different version locally than the centrally shared one? If not excluded we should warn the user (as this might behave differently).

Discussion

Should we have an option of ignoring or error-ing out on demand?
@FlorianRappl FlorianRappl added enhancement New feature or request cli Concerns the piral-cli application. pilets Concerns the API of the pilets. in-implementation The item is currently being implemented. labels Oct 17, 2023
@FlorianRappl FlorianRappl added this to the 1.3.1 milestone Oct 17, 2023
FlorianRappl added a commit that referenced this issue Oct 18, 2023
@FlorianRappl
Improved handling of dependency versions #635
b29c6a2
@FlorianRappl FlorianRappl added in-testing The item is already out in preview and can be tested. and removed in-implementation The item is currently being implemented. in-testing The item is already out in preview and can be tested. labels Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cli Concerns the piral-cli application. enhancement New feature or request pilets Concerns the API of the pilets.
Projects
None yet
Milestone
1.3.1
Development

No branches or pull requests
1 participant
@FlorianRappl