Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make App Name Configurable on Scaffold #546

Closed
FlorianRappl opened this issue Sep 29, 2022 · 0 comments · Fixed by #551
Closed

Make App Name Configurable on Scaffold #546

FlorianRappl opened this issue Sep 29, 2022 · 0 comments · Fixed by #551
Labels
cli Concerns the piral-cli application. enhancement New feature or request good first issue Good for newcomers
Milestone
0.15.0

Comments

@FlorianRappl
Copy link
Contributor

FlorianRappl commented Sep 29, 2022 •
edited
Loading

New Feature Proposal

For more information, see the CONTRIBUTING guide.

Description

Right now the Piral instance name is decided by the base name of the used directory (target). This should be made configurable, with the current setting (base name of the used directory) being the default.

Background

Maybe the directory is a bit misleading, the package should be scoped, or similar. We should support such cases without need to edit the package.json afterwards.

Discussion

What should the parameter name be? I think --app-name (i.e., having app-name / appName) would be good.

Implementation

Right now the project name is determined here https://github.com/smapiot/piral/blob/develop/src/tooling/piral-cli/src/apps/new-piral.ts#L138

It should be made available as options, where undefined is the default. This way, we can just assign basename(root) as default value when getting the appName from the options.
@FlorianRappl FlorianRappl added enhancement New feature or request good first issue Good for newcomers cli Concerns the piral-cli application. labels Sep 29, 2022
@github-actions github-actions bot mentioned this issue Oct 2, 2022
Merged
8 tasks
FlorianRappl added a commit that referenced this issue Oct 2, 2022
@FlorianRappl
Merge pull request #551 from mgarciaar/feature/#546-add-appName-argum…
c0d9ed7 
…ent-on-new-piral

Feature/#546 add app name argument on new piral
@FlorianRappl FlorianRappl linked a pull request Oct 2, 2022 that will close this issue
Feature/#546 add app name argument on new piral #551
Merged
8 tasks
@FlorianRappl FlorianRappl added this to the 0.15.0 milestone Oct 2, 2022
@mgarciaar mgarciaar mentioned this issue Oct 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cli Concerns the piral-cli application. enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
0.15.0
Development

Successfully merging a pull request may close this issue.

Feature/#546 add app name argument on new piral
1 participant
@FlorianRappl