Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make HMR port configurable #523

Closed
mingfang opened this issue Jun 6, 2022 · 1 comment
Closed

Make HMR port configurable #523

mingfang opened this issue Jun 6, 2022 · 1 comment
Labels
cli Concerns the piral-cli application. enhancement New feature or request webpack Concerns the integration of the Webpack bundler in the CLI.
Milestone
0.14.27

Comments

@mingfang
Copy link

mingfang commented Jun 6, 2022

Currently the HRM port is hardcoded to 62123 here

piral/src/tooling/piral-cli-webpack5/src/webpack/piral.ts

Line 87 in 036cb83

const hmrPort = options.hmr ? await getFreePort(62123) : 0;

Due to our network's configuration we can not use this port.
The problem can be resolved by making the HRM port configurable.
@mingfang mingfang added the enhancement New feature or request label Jun 6, 2022
@FlorianRappl FlorianRappl added cli Concerns the piral-cli application. webpack Concerns the integration of the Webpack bundler in the CLI. in-review The item is currently being reviewed. labels Jun 6, 2022
@FlorianRappl
Copy link
Contributor

Yes, we can do that.

@FlorianRappl FlorianRappl added in-implementation The item is currently being implemented. and removed in-review The item is currently being reviewed. labels Jun 6, 2022
FlorianRappl added a commit that referenced this issue Jun 6, 2022
@FlorianRappl
Implemented configurable --hmr-port #523
a727ace
@FlorianRappl FlorianRappl added in-testing The item is already out in preview and can be tested. and removed in-implementation The item is currently being implemented. labels Jun 6, 2022
@FlorianRappl FlorianRappl added this to the 0.14.27 milestone Jun 6, 2022
@FlorianRappl FlorianRappl removed the in-testing The item is already out in preview and can be tested. label Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cli Concerns the piral-cli application. enhancement New feature or request webpack Concerns the integration of the Webpack bundler in the CLI.
Projects
None yet
Milestone
0.14.27
Development

No branches or pull requests
2 participants
@mingfang @FlorianRappl